r36751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36750‎ | r36751 | r36752 >
Date:15:06, 27 June 2008
Author:demon
Status:old
Tags:
Comment:
Add no-ops for the (un)lock functions.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -706,5 +706,15 @@
707707 function getServer() {
708708 return $this->mServer;
709709 }
 710+
 711+ /**
 712+ * No-op lock functions
 713+ */
 714+ public function lock( $lockName, $method ) {
 715+ return true;
 716+ }
 717+ public function unlock( $lockName, $method ) {
 718+ return true;
 719+ }
710720
711721 } // end DatabaseOracle class
Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -997,6 +997,16 @@
998998 $this->query("$sql $matches[1],$matches[2])");
999999 }
10001000 }
 1001+
 1002+ /**
 1003+ * No-op lock functions
 1004+ */
 1005+ public function lock( $lockName, $method ) {
 1006+ return true;
 1007+ }
 1008+ public function unlock( $lockName, $method ) {
 1009+ return true;
 1010+ }
10011011
10021012 }
10031013
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -373,6 +373,16 @@
374374 $this->query("$sql $matches[1],$matches[2])");
375375 }
376376 }
 377+
 378+ /**
 379+ * No-op lock functions
 380+ */
 381+ public function lock( $lockName, $method ) {
 382+ return true;
 383+ }
 384+ public function unlock( $lockName, $method ) {
 385+ return true;
 386+ }
377387
378388 }
379389

Status & tagging log