r36660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r36659‎ | r36660 | r36661 >
Date:22:07, 25 June 2008
Author:rainman
Status:old
Tags:
Comment:
Do proper inheritance here instead of copy-paste of top level constructor.
Fixes problem with missing search results on Postgres, thanks to pyroplasm on IRC for pointing it out and testing.
Modified paths:
  • /trunk/phase3/includes/SearchPostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SearchPostgres.php
——@@ -219,7 +219,7 @@
220220 */
221221 class PostgresSearchResult extends SearchResult {
222222 function PostgresSearchResult( $row ) {
223 - $this->mTitle = Title::makeTitle( $row->page_namespace, $row->page_title );
 223+ parent::SearchResult($row);
224224 $this->score = $row->score;
225225 }
226226 function getScore() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r36874Cleanup for r36660: use PHP 5 __construct() name for constructors to make thi...brion02:02, 2 July 2008

Status & tagging log