r36340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36339‎ | r36340 | r36341 >
Date:16:19, 16 June 2008
Author:tstarling
Status:old
Tags:
Comment:
possible XSS
Modified paths:
  • /trunk/wiki2xml/php/mediawiki_converter.php (modified) (history)

Diff [purge]

Index: trunk/wiki2xml/php/mediawiki_converter.php
@@ -42,7 +42,7 @@
4343 }
4444 $xml = '<article' ;
4545 if ( $title != "" ) {
46 - $xml .= " title='{$title}'" ;
 46+ $xml .= ' title="' . htmlspecialchars( $title ) '"' ;
4747 $content_provider->add_article ( urldecode ( $ot ) ) ;
4848 }
4949 $xml .= '>' ;

Follow-up revisions

RevisionCommit summaryAuthorDate
r51756Fix breaking typo introduced by tstarling in r36340, noticed by Jan Rousmagnusmanske20:25, 11 June 2009

Status & tagging log