r36212 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36211‎ | r36212 | r36213 >
Date:00:51, 12 June 2008
Author:demon
Status:old
Tags:
Comment:
(bug 14500) - The sitefeed (RC) shouldn't show up on Recentchanges itself.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1419,12 +1419,12 @@
14201420 }
14211421
14221422 if( $wgFeed ) {
 1423+ global $wgTitle;
14231424 foreach( $this->getSyndicationLinks() as $format => $link ) {
14241425 # Use the page name for the title (accessed through $wgTitle since
14251426 # there's no other way). In principle, this could lead to issues
14261427 # with having the same name for different feeds corresponding to
14271428 # the same page, but we can't avoid that at this low a level.
1428 - global $wgTitle;
14291429
14301430 $ret .= $this->feedLink(
14311431 $format,
@@ -1432,19 +1432,24 @@
14331433 wfMsg( "page-{$format}-feed", $wgTitle->getPrefixedText() ) ); # Used messages: 'page-rss-feed' and 'page-atom-feed' (for an easier grep)
14341434 }
14351435
1436 - # Recent changes feed should appear on every page
1437 - # Put it after the per-page feed to avoid changing existing behavior.
1438 - # It's still available, probably via a menu in your browser.
1439 - global $wgSitename;
 1436+ # Recent changes feed should appear on every page (except recentchanges,
 1437+ # that would be redundant). Put it after the per-page feed to avoid
 1438+ # changing existing behavior. It's still available, probably via a
 1439+ # menu in your browser.
 1440+
14401441 $rctitle = SpecialPage::getTitleFor( 'Recentchanges' );
1441 - $ret .= $this->feedLink(
1442 - 'rss',
1443 - $rctitle->getFullURL( 'feed=rss' ),
1444 - wfMsg( 'site-rss-feed', $wgSitename ) );
1445 - $ret .= $this->feedLink(
1446 - 'atom',
1447 - $rctitle->getFullURL( 'feed=atom' ),
1448 - wfMsg( 'site-atom-feed', $wgSitename ) );
 1442+ if ( $wgTitle->getText() != $rctitle->getText() ) {
 1443+ global $wgSitename;
 1444+
 1445+ $ret .= $this->feedLink(
 1446+ 'rss',
 1447+ $rctitle->getFullURL( 'feed=rss' ),
 1448+ wfMsg( 'site-rss-feed', $wgSitename ) );
 1449+ $ret .= $this->feedLink(
 1450+ 'atom',
 1451+ $rctitle->getFullURL( 'feed=atom' ),
 1452+ wfMsg( 'site-atom-feed', $wgSitename ) );
 1453+ }
14491454 }
14501455
14511456 return $ret;
Index: trunk/phase3/RELEASE-NOTES
@@ -364,8 +364,9 @@
365365 * (bug 14479) MediaWiki:upload-maxfilesize should have a div id wrapper
366366 * (bug 14497) Throw visible errors in installer scripts when SQL files
367367 fail due to database permission or other error
 368+* (bug 14500) Site feed (Recentchanges) no longer shows up on the actual
 369+ recent changes page.
368370
369 -
370371 === API changes in 1.13 ===
371372
372373 * Fixing main page display in meta=siteinfo

Follow-up revisions

RevisionCommit summaryAuthorDate
r36270fix for r36212: take care of the namespace tooialex18:52, 13 June 2008

Status & tagging log