r36153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36152‎ | r36153 | r36154 >
Date:15:20, 10 June 2008
Author:tstarling
Status:old
Tags:
Comment:
Like the comment says... dieDebug() instead of wfHttpError
Modified paths:
  • /trunk/phase3/includes/api/ApiFormatBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFormatBase.php
@@ -287,9 +287,8 @@
288288 $feed->outItem($item);
289289 $feed->outFooter();
290290 } else {
291 - // Error has occured, print something usefull
292 - // TODO: make this error more informative using ApiBase :: dieDebug() or similar
293 - wfHttpError(500, 'Internal Server Error', '');
 291+ // Error has occured, print something useful
 292+ ApiBase::dieDebug( __METHOD__, 'Invalid feed class/item' );
294293 }
295294 }
296295

Follow-up revisions

RevisionCommit summaryAuthorDate
r36155Forgot this, needed with r36153tstarling15:38, 10 June 2008

Status & tagging log