r36095 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36094‎ | r36095 | r36096 >
Date:19:10, 9 June 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 14472) Special:Sitematrix was overly aggressive about calling wikis closed that have wgReadOnlyFile set -- it's not closed if the lockfile doesn't exist!
Modified paths:
  • /trunk/extensions/SiteMatrix/SiteMatrix_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SiteMatrix/SiteMatrix_body.php
@@ -113,7 +113,8 @@
114114 list( $major, $minor ) = $wgConf->siteFromDB( $dbname );
115115 if( $wgConf->get( 'wgReadOnly', $dbname, $major, array( 'site' => $major, 'lang' => $minor ) ) )
116116 return true;
117 - if( $wgConf->get( 'wgReadOnlyFile', $dbname, $major, array( 'site' => $major, 'lang' => $minor ) ) )
 117+ $readOnlyFile = $wgConf->get( 'wgReadOnlyFile', $dbname, $major, array( 'site' => $major, 'lang' => $minor ) );
 118+ if( $readOnlyFile && file_exists( $readOnlyFile ) )
118119 return true;
119120 return false;
120121 }

Status & tagging log