r35971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35970‎ | r35971 | r35972 >
Date:16:42, 6 June 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 14432) Fix notice regression in Special:Newpages feed mode
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialNewpages.php
@@ -105,7 +105,7 @@
106106 $this->setSyndicated();
107107 $feedType = $this->opts->getValue( 'feed' );
108108 if( $feedType ) {
109 - return $this->feed( $feedType, $options );
 109+ return $this->feed( $feedType );
110110 }
111111 }
112112
@@ -266,7 +266,7 @@
267267 * Output a subscription feed listing recent edits to this page.
268268 * @param string $type
269269 */
270 - protected function feed( $type, $options ) {
 270+ protected function feed( $type ) {
271271 require_once 'SpecialRecentchanges.php';
272272
273273 global $wgFeed, $wgFeedClasses;
Index: trunk/phase3/RELEASE-NOTES
@@ -343,6 +343,7 @@
344344 * (Bug 13828) Split parameter $1 of MediaWiki:Missingarticle into $1 (=title)
345345 and $2 (=revision numbers)
346346 * (bug 14401) Fix Safari access key tooltips for Windows and >3.1 Mac versions
 347+* (bug 14432) Fix notice regression in Special:Newpages feed mode
347348
348349
349350 === API changes in 1.13 ===

Status & tagging log