r35970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35969‎ | r35970 | r35971 >
Date:15:53, 6 June 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 14424) Fix regression in $wgRateLimitsExcludedGroups support

Fixes logic error introduced in r35908.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1102,13 +1102,11 @@
11031103 */
11041104 public function isPingLimitable() {
11051105 global $wgRateLimitsExcludedGroups;
1106 - if ( array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) == array() ||
1107 - !$this->isAllowed('noratelimit') ) {
1108 - return true;
1109 - }
1110 - else {
 1106+ if( array_intersect( $this->getEffectiveGroups(), $wgRateLimitsExcludedGroups ) ) {
 1107+ // Deprecated, but kept for backwards-compatibility config
11111108 return false;
11121109 }
 1110+ return !$this->isAllowed('noratelimit');
11131111 }
11141112
11151113 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r35908(bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding the 'nor...demon04:15, 5 June 2008

Status & tagging log