r35893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35892‎ | r35893 | r35894 >
Date:23:36, 4 June 2008
Author:brion
Status:old
Tags:
Comment:
Login & signup form float fixes:
* right float for RTL
* clear floats for the post-form text!

The float is only used to get the box to size nicely, as far as I can tell.
There ought to be a nice clean way to get boxes to auto-size nicely without making them tables or floats.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -1070,6 +1070,10 @@
10711071 background-color: #f9f9f9;
10721072 float: left;
10731073 }
 1074+.rtl div#userloginForm form,
 1075+.rtl div#userlogin form#userlogin2 {
 1076+ float: right;
 1077+}
10741078
10751079 div#userloginForm table,
10761080 div#userlogin form#userlogin2 table {
@@ -1088,6 +1092,9 @@
10891093 background-color: white;
10901094 }
10911095
 1096+#loginend, #signupend {
 1097+ clear: both;
 1098+}
10921099
10931100 #userloginprompt, #languagelinks {
10941101 font-size: 85%;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1337,7 +1337,7 @@
13381338 * to ensure that client-side caches don't keep obsolete copies of global
13391339 * styles.
13401340 */
1341 -$wgStyleVersion = '152';
 1341+$wgStyleVersion = '153';
13421342
13431343
13441344 # Server-side caching:

Status & tagging log