r35892 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r35891
|
r35892
|
r35893
>
Date:
23:24, 4 June 2008
Author:
aaron
Status:
old
Tags:
Comment:
Title may come in as an empty string, which is not null, so the previous fails and lets a bad title slip in, which can make errors
Modified paths:
/trunk/phase3/includes/api/ApiQueryBacklinks.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
—
—
@@ -264,8 +264,8 @@
265
265
$this->parseContinueParam();
266
266
else {
267
267
$title = $this->params['title'];
268
- if (!is_null($title)) {
269
- $this->rootTitle = Title :: newFromText($title);
268
+ if ( $title ) {
269
+ $this->rootTitle = Title::newFromText($title);
270
270
} else {
271
271
$this->dieUsageMsg(array('missingparam', 'title'));
272
272
}
Status & tagging log
15:27, 12 September 2011
Meno25
(
talk
|
contribs
)
changed the
status
of r35892
[
removed:
ok
added:
old]