r35795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35794‎ | r35795 | r35796 >
Date:14:56, 3 June 2008
Author:demon
Status:old
Tags:
Comment:
Partial revert of r35794. Additional file added to commit that shouldn't have gone.
Modified paths:
  • /trunk/phase3/config/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
@@ -597,7 +597,6 @@
598598 $conf->RootUser = importPost( "RootUser", "root" );
599599 $conf->RootPW = importPost( "RootPW", "" );
600600 $useRoot = importCheck( 'useroot', false );
601 - $createAdminSettings = importCheck('createadminsettings', false);
602601 $conf->LanguageCode = importPost( "LanguageCode", "en" );
603602
604603 ## MySQL specific:
@@ -1110,35 +1109,13 @@
11111110 }
11121111 if(fwrite( $f, $localSettings ) ) {
11131112 fclose( $f );
1114 - print "</li>\n";
 1113+ print "</li></ul><hr/>\n";
 1114+ writeSuccessMessage();
11151115 } else {
11161116 fclose( $f );
11171117 die("<p class='error'>An error occured while writing the config/LocalSettings.php file. Check user rights and disk space then try again.</p>\n");
11181118 print "</li></ul>\n";
11191119 }
1120 -
1121 - /* Create AdminSettings.php if we've enabled that */
1122 - if ( $createAdminSettings ){
1123 - print "<li style=\"list-style: none\">\n";
1124 - print "<p>Creating AdminSettings.php...</p>\n\n";
1125 - $f = file_get_contents( '../AdminSettings.sample' );
1126 -
1127 - if( $f == false ) {
1128 - dieout( "<p>Couldn't write out AdminSettings.php. Check that the directory permissions are correct.</p>\n" );
1129 - }
1130 -
1131 - $f = str_replace( 'wikiadmin', $conf->RootUser, $f );
1132 - $f = str_replace( 'adminpass', $conf->RootPW, $f );
1133 -
1134 - if ( file_put_contents( 'AdminSettings.php', $f ) ) {
1135 - print "</li>\n";
1136 - } else {
1137 - die("<p class='error'>An error occured while writing the config/AdminSettings.php file. Check user rights and disk space then try again.</p>\n");
1138 - print "</li></ul>\n";
1139 - }
1140 - }
1141 - print "</ul>\n<hr />";
1142 - writeSuccessMessage();
11431120
11441121 } while( false );
11451122 }
@@ -1406,17 +1383,7 @@
14071384 the database (if needed) or tables within it, please check the box and provide details
14081385 of a superuser account, such as <strong>root</strong>, which does.
14091386 </p>
1410 - <div class="config-input">
1411 - <label class="column">AdminSettings.php:</label>
1412 - <input type="checkbox" name="createadminsettings" id="createadminsettings" <?php if( $createAdminSettings ) { ?>checked="checked" <?php } ?>/>
1413 - &nbsp;<label for="useroot">Create AdminSettings.php</label>
1414 - </div>
14151387
1416 - <p class="config-desc">
1417 - If the superuser account above is specified, you can optionally create an AdminSettings.php
1418 - file. This is used for running the maintenance scripts.
1419 - </p>
1420 -
14211388 <?php database_switcher('mysql'); ?>
14221389 <div class="config-input"><?php
14231390 aField( $conf, "DBprefix", "Database table prefix:" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r35825Revert r35794, r35795, r35797, r35798 for now....brion22:43, 3 June 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r35794(bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding the 'nor...demon14:53, 3 June 2008

Status & tagging log