r35514 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35513‎ | r35514 | r35515 >
Date:19:35, 28 May 2008
Author:raymond
Status:old
Tags:
Comment:
(bug 14312) Update LanguageKaa.php for handling transform issues
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKaa.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageKaa.php
@@ -19,15 +19,33 @@
2020 /* Full code of function convertGrammar() is in development. Updates coming soon. */
2121 return $word;
2222 }
23 -
 23+ /*
 24+ * It fixes issue with ucfirst for transforming 'i' to 'İ'
 25+ *
 26+ */
2427 function ucfirst ( $string ) {
2528 if ( $string[0] == 'i' ) {
26 - return 'İ' . substr( $string, 1 );
 29+ $string = 'İ' . substr( $string, 1 );
2730 } else {
28 - return parent::ucfirst( $string );
 31+ $string = parent::ucfirst( $string );
2932 }
 33+ return $string;
 34+
3035 }
3136
 37+ /*
 38+ * It fixes issue with lcfirst for transforming 'I' to 'ı'
 39+ *
 40+ */
 41+ function lcfirst ( $string ) {
 42+ if ( $string[0] == 'I' ) {
 43+ $string = 'ı' . substr( $string, 1 );
 44+ } else {
 45+ $string = parent::lcfirst( $string );
 46+ }
 47+ return $string;
 48+ }
 49+
3250 /**
3351 * Avoid grouping whole numbers between 0 to 9999
3452 */
@@ -39,4 +57,4 @@
4058 }
4159 }
4260
43 -}
\ No newline at end of file
 61+}
Index: trunk/phase3/RELEASE-NOTES
@@ -307,8 +307,9 @@
308308 for better compatibility and keeping the links shorter. Avoids problem
309309 with corrupt links in Gmail on IE 6.
310310 * (bug 14273) Fix for HTTP Accept header parsing with spaces as from Konqueror
 311+* (bug 14312) Update LanguageKaa.php for handling transform issues with i to İ
 312+ and I to ı
311313
312 -
313314 === API changes in 1.13 ===
314315
315316 * Fixing main page display in meta=siteinfo

Status & tagging log