r34907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34906‎ | r34907 | r34908 >
Date:03:21, 16 May 2008
Author:aaron
Status:old
Tags:
Comment:
Actually check $edit ;)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -1904,10 +1904,10 @@
19051905 * @param Title $title
19061906 * @param Revision $rev
19071907 */
1908 - public static function revSubmitted( $title, $rev ) {
 1908+ public static function revSubmitted( $title, $rev, $edit ) {
19091909 global $wgRequest, $wgUser;
19101910 # Request was submitted
1911 - if( !$wgRequest->wasPosted() ) {
 1911+ if( !$edit || !$wgRequest->wasPosted() ) {
19121912 return false;
19131913 }
19141914 # Must be by this user
@@ -1942,7 +1942,7 @@
19431943 return true;
19441944 }
19451945 # For edits from normal form submits only!
1946 - if( !self::revSubmitted( $title, $rev ) ) {
 1946+ if( !self::revSubmitted( $title, $rev, $edit ) ) {
19471947 return true;
19481948 }
19491949 $frev = null;

Follow-up revisions

RevisionCommit summaryAuthorDate
r34982Revert r34906, r34907, r34928 -- mixing high-level data into low-level storag...brion15:53, 17 May 2008

Status & tagging log