r34282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34281‎ | r34282 | r34283 >
Date:23:24, 5 May 2008
Author:simetrical
Status:old
Tags:
Comment:
Just use User::getAllGroups() here, that's what it's there for.
Modified paths:
  • /trunk/extensions/Resign/SpecialResign.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Resign/SpecialResign.php
@@ -19,10 +19,8 @@
2020 );
2121
2222 # Add resign permission for every group set in the database
23 -foreach( $wgGroupPermissions as $key => $value ) {
24 - if( !in_array( $key, $wgImplicitGroups ) ) {
25 - $wgGroupPermissions[$key]['resign'] = true;
26 - }
 23+foreach( User::getAllGroups() as $group ) {
 24+ $wgGroupPermissions[$group]['resign'] = true;
2725 }
2826
2927 # Add log action

Follow-up revisions

RevisionCommit summaryAuthorDate
r34303Revert r34282. User class not created yet, causes fatal errors :(werdna10:49, 6 May 2008

Status & tagging log