r33376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33375‎ | r33376 | r33377 >
Date:17:33, 15 April 2008
Author:brion
Status:old
Tags:
Comment:
Temporarily remove the username option.
The index is missing on some wikis, and it seems a little funky to begin with.
Modified paths:
  • /trunk/phase3/includes/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialNewpages.php
@@ -64,6 +64,9 @@
6565 $options[$v] = $wgRequest->getText( $v, $options[$v] );
6666 }
6767 }
 68+
 69+ // hack disable
 70+ $options['username'] = '';
6871
6972 $wgOut->setSyndicated( true );
7073 $wgOut->setFeedAppendQuery( "namespace={$options['namespace']}&username={$options['username']}" );
@@ -113,6 +116,7 @@
114117 Xml::namespaceSelector( $options['namespace'], 'all' ) .
115118 "</td>
116119 </tr>
 120+ <!--
117121 <tr>
118122 <td align=\"$align\">" .
119123 Xml::label( wfMsg( 'newpages-username' ), 'mw-np-username' ) .
@@ -121,6 +125,7 @@
122126 Xml::input( 'username', 30, $options['username'], array( 'id' => 'mw-np-username' ) ) .
123127 "</td>
124128 </tr>
 129+ -->
125130 <tr> <td></td>
126131 <td>" .
127132 Xml::submitButton( wfMsg( 'allpagessubmit' ) ) .
@@ -304,9 +309,9 @@
305310 $conds['rc_new'] = 1;
306311 if( $this->namespace !== false ) {
307312 $conds['rc_namespace'] = $this->namespace;
308 - $rcIndexes = array( 'new_name_timestamp', 'rc_user_text' );
 313+ $rcIndexes = array( 'new_name_timestamp' );
309314 } else {
310 - $rcIndexes = array( 'rc_timestamp', 'rc_user_text' );
 315+ $rcIndexes = array( 'rc_timestamp' );
311316 }
312317 $conds[] = 'page_id = rc_cur_id';
313318 $conds['page_is_redirect'] = 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r34065Make the hack from r33376 conditional...brion23:49, 30 April 2008

Status & tagging log