r32956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32955‎ | r32956 | r32957 >
Date:12:22, 8 April 2008
Author:raymond
Status:old
Tags:
Comment:
Add a nice fieldset around the external search input form
Modified paths:
  • /trunk/phase3/includes/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -707,6 +707,7 @@
708708 'powersearch',
709709 'powersearch-legend',
710710 'powersearchtext',
 711+ 'search-external',
711712 'searchdisabled',
712713 'googlesearch',
713714 ),
Index: trunk/phase3/includes/SpecialSearch.php
@@ -143,13 +143,16 @@
144144 return;
145145 }
146146 global $wgInputEncoding;
147 - $wgOut->addHTML( wfMsg( 'searchdisabled' ) );
148 - $wgOut->addHTML(
 147+ $wgOut->addHTML(
 148+ Xml::openElement( 'fieldset' ) .
 149+ Xml::element( 'legend', null, wfMsg( 'search-external' ) ) .
 150+ Xml::element( 'p', array( 'class' => 'mw-searchdisabled' ), wfMsg( 'searchdisabled' ) ) .
149151 wfMsg( 'googlesearch',
150152 htmlspecialchars( $term ),
151153 htmlspecialchars( $wgInputEncoding ),
152154 htmlspecialchars( wfMsg( 'searchbutton' ) )
153 - )
 155+ ) .
 156+ Xml::closeElement( 'fieldset' )
154157 );
155158 wfProfileOut( $fname );
156159 return;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1300,6 +1300,7 @@
13011301 'powersearch' => 'Advanced search',
13021302 'powersearch-legend' => 'Advanced search',
13031303 'powersearchtext' => 'Search in namespaces:<br />$1<br />$2 List redirects<br />Search for $3 $9',
 1304+'search-external' => 'External search',
13041305 'searchdisabled' => '{{SITENAME}} search is disabled.
13051306 You can search via Google in the meantime.
13061307 Note that their indexes of {{SITENAME}} content may be out of date.',

Status & tagging log