r32345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32344‎ | r32345 | r32346 >
Date:03:25, 23 March 2008
Author:aaron
Status:old
Tags:
Comment:
When viewing a request, blue link the queue list items
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -762,25 +762,26 @@
763763
764764 $titleObj = Title::makeTitle( NS_SPECIAL, "ConfirmAccounts/{$this->specialPageParameter}" );
765765
766 - # Show other sub-queue links. Grey out the current one...
767 - if( $this->showStale || $this->showRejects || $this->showHeld ) {
 766+ # Show other sub-queue links. Grey out the current one.
 767+ # When viewing a request, show them all.
 768+ if( $this->acrID || $this->showStale || $this->showRejects || $this->showHeld ) {
768769 $listLink = $this->skin->makeKnownLinkObj( $titleObj, wfMsgHtml( 'confirmaccount-showopen' ) );
769770 } else {
770771 $listLink = wfMsgHtml( 'confirmaccount-showopen' );
771772 }
772 - if( !$this->showHeld ) {
 773+ if( $this->acrID || !$this->showHeld ) {
773774 $listLink .= ' | '.$this->skin->makeKnownLinkObj( $titleObj,
774775 wfMsgHtml( 'confirmaccount-showheld' ), wfArrayToCGI( array( 'wpShowHeld' => 1 ) ) );
775776 } else {
776777 $listLink .= ' | '.wfMsgHtml( 'confirmaccount-showheld' );
777778 }
778 - if( !$this->showRejects ) {
 779+ if( $this->acrID || !$this->showRejects ) {
779780 $listLink .= ' | '.$this->skin->makeKnownLinkObj( $titleObj, wfMsgHtml( 'confirmaccount-showrej' ),
780781 wfArrayToCGI( array( 'wpShowRejects' => 1 ) ) );
781782 } else {
782783 $listLink .= ' | '.wfMsgHtml( 'confirmaccount-showrej' );
783784 }
784 - if( !$this->showStale ) {
 785+ if( $this->acrID || !$this->showStale ) {
785786 $listLink .= ' | '.$this->skin->makeKnownLinkObj( $titleObj, wfMsgHtml( 'confirmaccount-showexp' ),
786787 wfArrayToCGI( array( 'wpShowStale' => 1 ) ) );
787788 } else {
@@ -1044,8 +1045,8 @@
10451046
10461047 $store = FileStore::get( 'accountreqs' );
10471048 if( !$store ) {
1048 - wfDebug( __METHOD__.": invalid storage group '{$store}'.\n" );
1049 - return false;
 1049+ wfDebug( __METHOD__.": invalid storage group '{$store}'.\n" );
 1050+ return false;
10501051 }
10511052 $store->stream( $key );
10521053 }

Status & tagging log