r32016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32015‎ | r32016 | r32017 >
Date:13:44, 15 March 2008
Author:btongminh
Status:old
Tags:
Comment:
(bug 7251) Sidebars generated by MediaWiki:Sidebar now have the class 'generated-sidebar'.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -149,7 +149,7 @@
150150 </div>
151151 <script type="<?php $this->text('jsmimetype') ?>"> if (window.isMSIE55) fixalpha(); </script>
152152 <?php foreach ($this->data['sidebar'] as $bar => $cont) { ?>
153 - <div class='portlet' id='p-<?php echo Sanitizer::escapeId($bar) ?>'<?php echo $skin->tooltip('p-'.$bar) ?>>
 153+ <div class='generated-sidebar portlet' id='p-<?php echo Sanitizer::escapeId($bar) ?>'<?php echo $skin->tooltip('p-'.$bar) ?>>
154154 <h5><?php $out = wfMsg( $bar ); if (wfEmptyMsg($bar, $out)) echo $bar; else echo $out; ?></h5>
155155 <div class='pBody'>
156156 <ul>
Index: trunk/phase3/RELEASE-NOTES
@@ -93,8 +93,9 @@
9494 * (bug 2084) Fixed incorrect regex to match redirects
9595 * (bug 3131) Manually-specified upload destination filename is no longer
9696 overwritten by browsing for a file after you wrote it.
 97+* (bug 7251) Sidebars generated by MediaWiki:Sidebar now have the class
 98+ 'generated-sidebar'.
9799
98 -
99100 === API changes in 1.13 ===
100101
101102 * Fixing main page display in meta=siteinfo

Follow-up revisions

RevisionCommit summaryAuthorDate
r32017Also applying r32016 to the Modern skin.btongminh13:50, 15 March 2008

Status & tagging log