r31794 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31793‎ | r31794 | r31795 >
Date:16:29, 11 March 2008
Author:ialex
Status:old
Tags:
Comment:
Fixed comments in skins/*.deps.php, I expect that this is the good mail, the other one returned a 404 not found.
Modified paths:
  • /trunk/phase3/skins/Chick.deps.php (modified) (history)
  • /trunk/phase3/skins/Modern.deps.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.deps.php (modified) (history)
  • /trunk/phase3/skins/MySkin.deps.php (modified) (history)
  • /trunk/phase3/skins/Simple.deps.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MySkin.deps.php
@@ -3,7 +3,7 @@
44 // MySkin.php is compiled, working around a bug in the APC opcode
55 // cache on PHP 5, where cached code can break if the include order
66 // changed on a subsequent page view.
7 -// see http://mail.wikipedia.org/pipermail/wikitech-l/2006-January/033660.html
 7+// see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
88
99 if ( ! defined( 'MEDIAWIKI' ) )
1010 die( 1 );
Index: trunk/phase3/skins/Chick.deps.php
@@ -3,7 +3,7 @@
44 // Chick.php is compiled, working around a bug in the APC opcode
55 // cache on PHP 5, where cached code can break if the include order
66 // changed on a subsequent page view.
7 -// see http://mail.wikipedia.org/pipermail/wikitech-l/2006-January/033660.html
 7+// see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
88
99 if ( ! defined( 'MEDIAWIKI' ) )
1010 die( 1 );
Index: trunk/phase3/skins/MonoBook.deps.php
@@ -3,7 +3,7 @@
44 // MonoBook.php is compiled, working around a bug in the APC opcode
55 // cache on PHP 5, where cached code can break if the include order
66 // changed on a subsequent page view.
7 -// see http://mail.wikipedia.org/pipermail/wikitech-l/2006-January/033660.html
 7+// see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
88
99 if ( ! defined( 'MEDIAWIKI' ) )
1010 die( 1 );
Index: trunk/phase3/skins/Modern.deps.php
@@ -1,13 +1,12 @@
22 <?php
33 // This file exists to ensure that base classes are preloaded before
4 -// Simple.php is compiled, working around a bug in the APC opcode
 4+// Modern.php is compiled, working around a bug in the APC opcode
55 // cache on PHP 5, where cached code can break if the include order
66 // changed on a subsequent page view.
7 -// see http://mail.wikipedia.org/pipermail/wikitech-l/2006-January/033660.html
 7+// see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
88
99 if ( ! defined( 'MEDIAWIKI' ) )
1010 die( 1 );
1111
12 -require_once( dirname( dirname( __FILE__ ) ) . '/includes/SkinTemplate.php');
13 -require_once( dirname(__FILE__) . '/Modern.php' );
 12+require_once( dirname( dirname( __FILE__ ) ) . '/includes/SkinTemplate.php' );
1413
Index: trunk/phase3/skins/Simple.deps.php
@@ -3,7 +3,7 @@
44 // Simple.php is compiled, working around a bug in the APC opcode
55 // cache on PHP 5, where cached code can break if the include order
66 // changed on a subsequent page view.
7 -// see http://mail.wikipedia.org/pipermail/wikitech-l/2006-January/033660.html
 7+// see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
88
99 if ( ! defined( 'MEDIAWIKI' ) )
1010 die( 1 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r31801(in continuation of r31794) Fixed comments in languages/classes/*.deps.php.ialex17:23, 11 March 2008

Status & tagging log