r31784 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31783‎ | r31784 | r31785 >
Date:14:50, 11 March 2008
Author:gri6507
Status:old
Tags:
Comment:
fixed a minor bug in displaying the list; used to sometimes cause "Bad Title" error
Modified paths:
  • /trunk/extensions/WhiteList/SpecialWhitelistEdit.php (modified) (history)
  • /trunk/extensions/WhiteList/SpecialWhitelistEdit_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WhiteList/SpecialWhitelistEdit_body.php
@@ -351,10 +351,7 @@
352352 for ($row = $dbr->fetchObject($res); $row; $row = $dbr->fetchObject($res)) {
353353 $wgOut->addHtml("<tr><td><center><input type='checkbox' name='cb_modify[]' value='$row->wl_id'></center></td><td>");
354354 $page_title = Title::newFromText($row->wl_page_title);
355 - if ($page_title == NULL)
356 - $wgOut->addHtml(wfMsg('whitelistbadtitle') . $row->wl_page_title);
357 - else
358 - self::DisplayWildCardMatches($row->wl_page_title, $row->wl_page_title, 0);
 355+ self::DisplayWildCardMatches($row->wl_page_title, $row->wl_page_title, 0);
359356 $wgOut->addHTML("</td><td><center>");
360357 if ($row->wl_allow_edit)
361358 $wgOut->addHtml(wfMsg('whitelisttableedit'));
Index: trunk/extensions/WhiteList/SpecialWhitelistEdit.php
@@ -31,7 +31,7 @@
3232
3333 $wgExtensionCredits['specialpage'][] = array(
3434 'name' => 'WhiteListEdit',
35 - 'version' => 'v0.8.1',
 35+ 'version' => 'v0.8.2',
3636 'author' => array('Paul Grinberg', 'Mike Sullivan'),
3737 'email' => 'gri6507 at yahoo dot com, ms-mediawiki AT umich DOT edu',
3838 'description' => 'Edit the access permissions of restricted users',

Status & tagging log