r30146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30145‎ | r30146 | r30147 >
Date:10:15, 25 January 2008
Author:tstarling
Status:old
Tags:
Comment:
Fixed broken HTML
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileDeleteForm.php
@@ -149,20 +149,20 @@
150150 }
151151
152152 $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->getAction() ) );
 153+ $form .= '<fieldset><legend>' . wfMsgHtml( 'filedelete-legend' ) . '</legend>';
153154 $form .= Xml::hidden( 'wpEditToken', $wgUser->editToken( $this->oldimage ) );
154 - $form .= '<fieldset><legend>' . wfMsgHtml( 'filedelete-legend' ) . '</legend>';
155 - $form .= '<table><tr>';
 155+ $form .= '<table><tr><td colspan="2">';
156156 $form .= $this->prepareMessage( 'filedelete-intro' );
157 - $form .= "<td align=\"right\"> $delcom </td><td align=\"left\">";
 157+ $form .= "</td></tr><tr><td align=\"right\"> $delcom </td><td align=\"left\">";
158158 $form .= "<select tabindex='2' id='wpDeleteReasonList' name=\"wpDeleteReasonList\">
159159 $deleteReasonList
160160 </select>";
161 - $form .= "</tr><tr><td align=\"right\"> $mDeletereasonother </td><td align=\"left\">";
 161+ $form .= "</td></tr><tr><td align=\"right\"> $mDeletereasonother </td><td align=\"left\">";
162162 $form .= "<input type='text' maxlength='255' size='60' name='wpReason' id='wpReason' ";
163163 $form .= "value=\"". htmlspecialchars( $wgRequest->getText( 'wpReason' ) ) ."\" tabindex=\"1\" />";
164 - $form .= '</td></tr><tr><td colspan=2>';
 164+ $form .= '</td></tr><tr><td colspan="2">';
165165 $form .= '<p>' . Xml::submitButton( wfMsg( 'filedelete-submit' ), array( 'name' => 'mw-filedelete-submit', 'id' => 'mw-filedelete-submit' ) ) . '</p>';
166 - $form .= '</tr></table>';
 166+ $form .= '</td></tr></table>';
167167 $form .= '</fieldset>';
168168 $form .= '</form>';
169169
@@ -272,4 +272,4 @@
273273 return $this->oldfile->getTimestamp();
274274 }
275275
276 -}
\ No newline at end of file
 276+}

Status & tagging log