r30110 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30109‎ | r30110 | r30111 >
Date:11:21, 24 January 2008
Author:huji
Status:old
Tags:
Comment:
(bug 12738) Database query syntax error in maintenance/storage/compressOld.inc
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/maintenance/storage/compressOld.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/storage/compressOld.inc
@@ -15,7 +15,7 @@
1616 print "Starting from old_id $start...\n";
1717 $dbw = wfGetDB( DB_MASTER );
1818 do {
19 - $res = $dbw->select( 'text', array( 'old_id','old_flags','old_namespace','old_title','old_text' ),
 19+ $res = $dbw->select( 'text', array( 'old_id','old_flags','old_text' ),
2020 "old_id>=$start", $fname, array( 'ORDER BY' => 'old_id', 'LIMIT' => $chunksize, 'FOR UPDATE' ) );
2121 if( $dbw->numRows( $res ) == 0 ) {
2222 break;
Index: trunk/phase3/includes/ProtectionForm.php
@@ -341,6 +341,9 @@
342342 return '<tr>'
343343 . '<td><label for="expires">' . wfMsgExt( 'protectexpiry', array( 'parseinline' ) ) . '</label></td>'
344344 . '<td>' . Xml::input( 'mwProtect-expiry', 60, $this->mExpiry, $attribs ) . '</td>'
 345+ . '</tr><tr>'
 346+ . '<td><label for="expires">' . wfMsgExt( 'protectexpiry', array( 'parseinline' ) ) . '</label></td>'
 347+ . '<td>' . Xml::input( 'mwProtect-expiry', 60, $this->mExpiry, $attribs ) . '</td>'
345348 . '</tr>';
346349 }
347350
Index: trunk/phase3/RELEASE-NOTES
@@ -335,8 +335,8 @@
336336 * (bug 12327) Comma in username no longer disrupts mail headers
337337 * (bug 6436) Localization of Special:Import XML parser Error message(s).
338338 * Security fix for API on MSIE
 339+* (bug 12768) Database query syntax error in maintenance/storage/compressOld.inc
339340
340 -
341341 == Parser changes in 1.12 ==
342342
343343 The parser pass order has changed from

Follow-up revisions

RevisionCommit summaryAuthorDate
r30121partly revert of r30110. looks like an accident.raymond13:58, 24 January 2008

Status & tagging log