r29789 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29788‎ | r29789 | r29790 >
Date:14:48, 15 January 2008
Author:simetrical
Status:old
Tags:
Comment:
(bug 12202) Strict standards: mark static methods static.
Modified paths:
  • /trunk/phase3/includes/ExternalStore.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStore.php
@@ -1,18 +1,15 @@
22 <?php
33 /**
4 - *
5 - *
64 * Constructor class for data kept in external repositories
75 *
86 * External repositories might be populated by maintenance/async
97 * scripts, thus partial moving of data may be possible, as well
108 * as possibility to have any storage format (i.e. for archives)
11 - *
129 */
1310
1411 class ExternalStore {
1512 /* Fetch data from given URL */
16 - function fetchFromURL($url) {
 13+ static function fetchFromURL($url) {
1714 global $wgExternalStores;
1815
1916 if (!$wgExternalStores)
@@ -32,7 +29,7 @@
3330 /**
3431 * Get an external store object of the given type
3532 */
36 - function &getStoreObject( $proto ) {
 33+ static function &getStoreObject( $proto ) {
3734 global $wgExternalStores;
3835 if (!$wgExternalStores)
3936 return false;
@@ -55,7 +52,7 @@
5653 * class itself as a parameter.
5754 * Returns the URL of the stored data item, or false on error
5855 */
59 - function insert( $url, $data ) {
 56+ static function insert( $url, $data ) {
6057 list( $proto, $params ) = explode( '://', $url, 2 );
6158 $store =& ExternalStore::getStoreObject( $proto );
6259 if ( $store === false ) {

Status & tagging log