r28788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28787‎ | r28788 | r28789 >
Date:02:41, 23 December 2007
Author:simetrical
Status:old
Tags:
Comment:
Revert extraneous parts of last commit, I didn't mean to check in cruddy half-finished garbage on edit section links that I was about to throw out anyway.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE50Fixes.css
@@ -64,3 +64,4 @@
6565 margin: 0;
6666 }
6767 .firstHeading { margin-bottom: .3em; }
 68+/*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/monobook/IE60Fixes.css
@@ -80,8 +80,5 @@
8181 div.tleft {
8282 position: relative;
8383 }
 84+/*{ border:1px solid Red !important;}*/
8485
85 -/* IE 5, 5.5, 6 ignore the space in between the header and the link. We can
86 - * fix this with a margin for 5.5 and 6, but 5 ignores margins on inline
87 - * elements, so that looks a little uglier. */
88 -.editsection { margin-left: 0.3em; }
Index: trunk/phase3/skins/monobook/IE55Fixes.css
@@ -83,9 +83,3 @@
8484 #editform {
8585 width: 100%;
8686 }
87 -
88 -
89 -/* IE 5, 5.5, 6 ignore the space in between the header and the link. We can
90 - * fix this with a margin for 5.5 and 6, but 5 ignores margins on inline
91 - * elements, so that looks a little uglier. */
92 -.editsection { margin-left: 0.3em; }
Index: trunk/phase3/skins/monobook/main.css
@@ -111,28 +111,31 @@
112112 margin: .2em 0 .2em 0;
113113 }
114114
115 -.mw-h1, .mw-h2, .mw-h3, .mw-h4, .mw-h5, .mw-h6 {
 115+h1, h2, h3, h4, h5, h6 {
116116 color: black;
117117 background: none;
 118+ font-weight: normal;
118119 margin: 0;
119120 padding-top: .5em;
120121 padding-bottom: .17em;
121122 border-bottom: 1px solid #aaa;
122123 }
123 -h1, h2, h3, h4, h5, h6 {
124 - font-weight: normal;
125 - display: inline;
126 -}
127124 h1 { font-size: 188%; }
 125+h1 .editsection { font-size: 53%; }
128126 h2 { font-size: 150%; }
 127+h2 .editsection { font-size: 67%; }
129128 h3, h4, h5, h6 {
130129 border-bottom: none;
131130 font-weight: bold;
132131 }
133132 h3 { font-size: 132%; }
 133+h3 .editsection { font-size: 76%; font-weight: normal; }
134134 h4 { font-size: 116%; }
 135+h4 .editsection { font-size: 86%; font-weight: normal; }
135136 h5 { font-size: 100%; }
 137+h5 .editsection { font-weight: normal; }
136138 h6 { font-size: 80%; }
 139+h6 .editsection { font-size: 125%; font-weight: normal; }
137140
138141 ul {
139142 line-height: 1.5em;
Index: trunk/phase3/skins/common/oldshared.css
@@ -4,6 +4,28 @@
55 * CologneBlue, the old pre-Monobook skins
66 */
77
 8+/* For clarity, explicitly state some recommendations from <http://www.w3.org/
 9+ TR/CSS21/sample.html> to make sure the editsection links scale right */
 10+
 11+h1 { font-size: 2em; }
 12+h2 { font-size: 1.5em; }
 13+h3 { font-size: 1.17em; }
 14+h5 { font-size: .83em; }
 15+h6 { font-size: .75em; }
 16+h1, h2, h3, h4, h5, h6 { font-weight: bolder }
 17+
 18+/* Now the custom parts */
 19+
 20+/* Make edit sections (which are inside h# tags) normal-sized */
 21+.editsection {
 22+ font-weight: normal;
 23+}
 24+h1 .editsection { font-size: 50% }
 25+h2 .editsection { font-size: 66.7% }
 26+h3 .editsection { font-size: 85.5% }
 27+h5 .editsection { font-size: 120% }
 28+h6 .editsection { font-size: 133% }
 29+
830 #footer { clear: both }
931 /* images */
1032 div.floatright { float: right; clear: right; margin: 0 0 1em 1em; }
Index: trunk/phase3/skins/common/shared.css
@@ -19,6 +19,12 @@
2020 background-color: #fcfcfc;
2121 }
2222
 23+/* Edit section links */
 24+.editsection {
 25+ float: right;
 26+ margin-left: 5px;
 27+}
 28+
2329 /**
2430 * File histories
2531 */
Index: trunk/phase3/includes/Linker.php
@@ -1225,11 +1225,7 @@
12261226 * @return string HTML headline
12271227 */
12281228 public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
1229 - # See related bugs 1629, 11270, 11555.
1230 - return "<a name=\"$anchor\"></a>
1231 -<div class=\"mw-h$level\">
1232 - <h$level$attribs$text</h$level> $link
1233 -</div>";
 1229+ return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
12341230 }
12351231
12361232 /**
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1246,7 +1246,7 @@
12471247 * to ensure that client-side caches don't keep obsolete copies of global
12481248 * styles.
12491249 */
1250 -$wgStyleVersion = '105';
 1250+$wgStyleVersion = '104';
12511251
12521252
12531253 # Server-side caching:

Status & tagging log