r28787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28786‎ | r28787 | r28788 >
Date:02:21, 23 December 2007
Author:simetrical
Status:old
Tags:
Comment:
Fix last commit adding ID's, I didn't want to remove the <p>'s.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE50Fixes.css
@@ -64,4 +64,3 @@
6565 margin: 0;
6666 }
6767 .firstHeading { margin-bottom: .3em; }
68 -/*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/monobook/IE60Fixes.css
@@ -80,5 +80,8 @@
8181 div.tleft {
8282 position: relative;
8383 }
84 -/*{ border:1px solid Red !important;}*/
8584
 85+/* IE 5, 5.5, 6 ignore the space in between the header and the link. We can
 86+ * fix this with a margin for 5.5 and 6, but 5 ignores margins on inline
 87+ * elements, so that looks a little uglier. */
 88+.editsection { margin-left: 0.3em; }
Index: trunk/phase3/skins/monobook/IE55Fixes.css
@@ -83,3 +83,9 @@
8484 #editform {
8585 width: 100%;
8686 }
 87+
 88+
 89+/* IE 5, 5.5, 6 ignore the space in between the header and the link. We can
 90+ * fix this with a margin for 5.5 and 6, but 5 ignores margins on inline
 91+ * elements, so that looks a little uglier. */
 92+.editsection { margin-left: 0.3em; }
Index: trunk/phase3/skins/monobook/main.css
@@ -111,31 +111,28 @@
112112 margin: .2em 0 .2em 0;
113113 }
114114
115 -h1, h2, h3, h4, h5, h6 {
 115+.mw-h1, .mw-h2, .mw-h3, .mw-h4, .mw-h5, .mw-h6 {
116116 color: black;
117117 background: none;
118 - font-weight: normal;
119118 margin: 0;
120119 padding-top: .5em;
121120 padding-bottom: .17em;
122121 border-bottom: 1px solid #aaa;
123122 }
 123+h1, h2, h3, h4, h5, h6 {
 124+ font-weight: normal;
 125+ display: inline;
 126+}
124127 h1 { font-size: 188%; }
125 -h1 .editsection { font-size: 53%; }
126128 h2 { font-size: 150%; }
127 -h2 .editsection { font-size: 67%; }
128129 h3, h4, h5, h6 {
129130 border-bottom: none;
130131 font-weight: bold;
131132 }
132133 h3 { font-size: 132%; }
133 -h3 .editsection { font-size: 76%; font-weight: normal; }
134134 h4 { font-size: 116%; }
135 -h4 .editsection { font-size: 86%; font-weight: normal; }
136135 h5 { font-size: 100%; }
137 -h5 .editsection { font-weight: normal; }
138136 h6 { font-size: 80%; }
139 -h6 .editsection { font-size: 125%; font-weight: normal; }
140137
141138 ul {
142139 line-height: 1.5em;
Index: trunk/phase3/skins/common/oldshared.css
@@ -4,28 +4,6 @@
55 * CologneBlue, the old pre-Monobook skins
66 */
77
8 -/* For clarity, explicitly state some recommendations from <http://www.w3.org/
9 - TR/CSS21/sample.html> to make sure the editsection links scale right */
10 -
11 -h1 { font-size: 2em; }
12 -h2 { font-size: 1.5em; }
13 -h3 { font-size: 1.17em; }
14 -h5 { font-size: .83em; }
15 -h6 { font-size: .75em; }
16 -h1, h2, h3, h4, h5, h6 { font-weight: bolder }
17 -
18 -/* Now the custom parts */
19 -
20 -/* Make edit sections (which are inside h# tags) normal-sized */
21 -.editsection {
22 - font-weight: normal;
23 -}
24 -h1 .editsection { font-size: 50% }
25 -h2 .editsection { font-size: 66.7% }
26 -h3 .editsection { font-size: 85.5% }
27 -h5 .editsection { font-size: 120% }
28 -h6 .editsection { font-size: 133% }
29 -
308 #footer { clear: both }
319 /* images */
3210 div.floatright { float: right; clear: right; margin: 0 0 1em 1em; }
Index: trunk/phase3/skins/common/shared.css
@@ -19,12 +19,6 @@
2020 background-color: #fcfcfc;
2121 }
2222
23 -/* Edit section links */
24 -.editsection {
25 - float: right;
26 - margin-left: 5px;
27 -}
28 -
2923 /**
3024 * File histories
3125 */
Index: trunk/phase3/includes/Linker.php
@@ -1225,7 +1225,11 @@
12261226 * @return string HTML headline
12271227 */
12281228 public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
1229 - return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 1229+ # See related bugs 1629, 11270, 11555.
 1230+ return "<a name=\"$anchor\"></a>
 1231+<div class=\"mw-h$level\">
 1232+ <h$level$attribs$text</h$level> $link
 1233+</div>";
12301234 }
12311235
12321236 /**
Index: trunk/phase3/includes/EditPage.php
@@ -1056,9 +1056,9 @@
10571057 }
10581058
10591059 if( wfReadOnly() ) {
1060 - $wgOut->addWikiText( '<div id="mw-read-only-warning">'.wfMsg( 'readonlywarning' ).'</div>' );
 1060+ $wgOut->addHTML( '<div id="mw-read-only-warning">'.wfMsgWikiHTML( 'readonlywarning' ).'</div>' );
10611061 } elseif( $wgUser->isAnon() && $this->formtype != 'preview' ) {
1062 - $wgOut->addWikiText( '<div id="mw-anon-edit-warning">'.wfMsg( 'anoneditwarning' ).'</div>' );
 1062+ $wgOut->addHTML( '<div id="mw-anon-edit-warning">'.wfMsgWikiHTML( 'anoneditwarning' ).'</div>' );
10631063 } else {
10641064 if( $this->isCssJsSubpage && $this->formtype != 'preview' ) {
10651065 # Check the skin exists
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1246,7 +1246,7 @@
12471247 * to ensure that client-side caches don't keep obsolete copies of global
12481248 * styles.
12491249 */
1250 -$wgStyleVersion = '104';
 1250+$wgStyleVersion = '105';
12511251
12521252
12531253 # Server-side caching:

Status & tagging log