r28422 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28421‎ | r28422 | r28423 >
Date:22:48, 12 December 2007
Author:david
Status:old
Tags:
Comment:
Footer links hover highlight now more specific. Sig links can also highlight, but I haven't found a working color palette yet.
Modified paths:
  • /trunk/extensions/LiquidThreads/LqtBaseView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -395,27 +395,27 @@
396396 border-color: #aaa;
397397 }*/
398398
399 -.lqt_post .lqt_footer:hover a, .lqt_nonindent_message:hover a, .lqt_threadlevel_commands:hover a {
 399+.lqt_post .lqt_footer .lqt_footer_commands:hover a, .lqt_nonindent_message:hover a, .lqt_threadlevel_commands:hover a {
400400 color: #002bb8;
401401 text-decoration: none;
402402 }
403 -.lqt_post .lqt_footer:hover a:visited, .lqt_nonindent_message:hover a:visited, .lqt_threadlevel_commands:hover a:visited {
 403+.lqt_post .lqt_footer .lqt_footer_commands:hover a:visited, .lqt_nonindent_message:hover a:visited, .lqt_threadlevel_commands:hover a:visited {
404404 color: #5a3696;
405405 text-decoration: none;
406406 }
407 -.lqt_post .lqt_footer:hover a:active, .lqt_nonindent_message:hover a:active, .lqt_threadlevel_commands:hover a:active {
 407+.lqt_post .lqt_footer .lqt_footer_commands:hover a:active, .lqt_nonindent_message:hover a:active, .lqt_threadlevel_commands:hover a:active {
408408 color: #faa700;
409409 text-decoration: none;
410410 }
411 -.lqt_post .lqt_footer:hover a.stub, .lqt_nonindent_message:hover a.stub, .lqt_threadlevel_commands:hover a.stub {
 411+.lqt_post .lqt_footer .lqt_footer_commands:hover a.stub, .lqt_nonindent_message:hover a.stub, .lqt_threadlevel_commands:hover a.stub {
412412 color: #772233;
413413 text-decoration: none;
414414 }
415 -.lqt_post .lqt_footer:hover a.new, #p-personal a.new, .lqt_threadlevel_commands:hover a.new, .lqt_nonindent_message:hover a.new, #p-personal a.new, .lqt_threadlevel_commands:hover a.new, #p-personal a.new {
 415+.lqt_post .lqt_footer .lqt_footer_commands:hover a.new, #p-personal a.new, .lqt_threadlevel_commands:hover a.new, .lqt_nonindent_message:hover a.new, #p-personal a.new, .lqt_threadlevel_commands:hover a.new, #p-personal a.new {
416416 color: #ba0000;
417417 text-decoration: none;
418418 }
419 -.lqt_post .lqt_footer:hover a.new:visited, #p-personal a.new:visited, .lqt_threadlevel_commands:hover a.new:visited, .lqt_nonindent_message:hover a.new:visited, #p-personal a.new:visited, .lqt_threadlevel_commands:hover a.new:visited, #p-personal a.new:visited {
 419+.lqt_post .lqt_footer .lqt_footer_commands:hover a.new:visited, #p-personal a.new:visited, .lqt_threadlevel_commands:hover a.new:visited, .lqt_nonindent_message:hover a.new:visited, #p-personal a.new:visited, .lqt_threadlevel_commands:hover a.new:visited, #p-personal a.new:visited {
420420 color: #a55858;
421421 text-decoration: none;
422422 }
@@ -438,6 +438,13 @@
439439 .lqt_post_color_5 a { color: #0098cd !important; }
440440 .lqt_post_color_6 a { color: #00cd98 !important; }
441441
 442+.lqt_footer_sig:hover .lqt_post_color_1 a { color: #cd9800 !important; }
 443+.lqt_footer_sig:hover .lqt_post_color_2 a { color: #cd0098 !important; }
 444+.lqt_footer_sig:hover .lqt_post_color_3 a { color: #98cd00 !important; }
 445+.lqt_footer_sig:hover .lqt_post_color_4 a { color: #9800cd !important; }
 446+.lqt_footer_sig:hover .lqt_post_color_5 a { color: #0098cd !important; }
 447+.lqt_footer_sig:hover .lqt_post_color_6 a { color: #00cd98 !important; }
 448+.lqt_footer_sig:hover a { text-decoration: none; }
442449
443450 li#ca-nstab-thread {
444451 /* from #ca-talk */
Index: trunk/extensions/LiquidThreads/LqtBaseView.php
@@ -704,6 +704,14 @@
705705 }
706706 }
707707
 708+ function colorTest() {
 709+ $this->output->addHTML( '<div class="lqt_footer"><li class="lqt_footer_sig">' );
 710+ for( $i = 1; $i <= self::number_of_user_colors; $i++ ) {
 711+ $this->output->addHTML("<span class=\"lqt_post_color_{$i}\"><a href=\"foo\">DavidMcCabe</a></span>");
 712+ }
 713+ $this->output->addHTML('</li></div>');
 714+ }
 715+
708716 function showThreadFooter( $thread ) {
709717 global $wgLang; // TODO global.
710718
@@ -717,6 +725,7 @@
718726
719727 $this->output->addHTML(<<<HTML
720728 <ul class="lqt_footer">
 729+<span class="lqt_footer_sig">
721730 <li class="lqt_author_sig lqt_post_color_{$color_number}">$sig</li>
722731 HTML
723732 );
@@ -729,9 +738,11 @@
730739 $this->output->addHTML("<li class=\"lqt_edited_notice lqt_post_color_{$editedness_color_number}\">".'<a href="'.$editedness_url.'">'.wfMsg('lqt_edited_notice').'</a>'.'</li>');
731740 }
732741
733 - $this->output->addHTML("<li>$timestamp</li>");
 742+ $this->output->addHTML("</span><li>$timestamp</li>");
734743
735 - $this->output->addHTML($this->listItemsForCommands($this->threadFooterCommands($thread)));
 744+ $this->output->addHTML('<span class="lqt_footer_commands">' .
 745+ $this->listItemsForCommands($this->threadFooterCommands($thread)) .
 746+ '</span>');
736747
737748 $this->output->addHTML('</ul>');
738749 }
@@ -833,7 +844,7 @@
834845
835846 function showThread( $thread ) {
836847 global $wgLang; # TODO global.
837 -
 848+
838849 if( $this->lastUnindentedSuperthread ) {
839850 $tmp = $this->lastUnindentedSuperthread;
840851 $msg = wfMsg('lqt_in_response_to',

Status & tagging log