r28137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28136‎ | r28137 | r28138 >
Date:11:12, 4 December 2007
Author:raymond
Status:old
Tags:
Comment:
* (bug 11993) Remove contentsub "revision history", it is useless because it is already in the page title
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/PageHistory.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
@@ -70,10 +70,8 @@
7171
7272 $logPage = SpecialPage::getTitleFor( 'Log' );
7373 $logLink = $this->mSkin->makeKnownLinkObj( $logPage, wfMsgHtml( 'viewpagelogs' ), 'page=' . $this->mTitle->getPrefixedUrl() );
 74+ $wgOut->setSubtitle( $logLink );
7475
75 - $subtitle = wfMsgHtml( 'revhistory' ) . '<br />' . $logLink;
76 - $wgOut->setSubtitle( $subtitle );
77 -
7876 $feedType = $wgRequest->getVal( 'feed' );
7977 if( $feedType ) {
8078 wfProfileOut( $fname );
@@ -89,7 +87,6 @@
9088 return;
9189 }
9290
93 -
9491 /*
9592 * "go=first" means to jump to the last (earliest) history page.
9693 * This is deprecated, it no longer appears in the user interface
@@ -99,7 +96,7 @@
10097 $wgOut->redirect( $wgTitle->getLocalURL( "action=history&limit={$limit}&dir=prev" ) );
10198 return;
10299 }
103 -
 100+
104101 wfRunHooks( 'PageHistoryBeforeList', array( &$this->mArticle ) );
105102
106103 /**
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1102,7 +1102,6 @@
11031103 The reason given by $3 is ''$2''",
11041104
11051105 # History pages
1106 -'revhistory' => 'Revision history',
11071106 'viewpagelogs' => 'View logs for this page',
11081107 'nohistory' => 'There is no edit history for this page.',
11091108 'revnotfound' => 'Revision not found',
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -775,7 +775,6 @@
776776 Grund der Sperre: ''$2''",
777777
778778 # History pages
779 -'revhistory' => 'Frühere Versionen',
780779 'viewpagelogs' => 'Logbücher für diese Seite anzeigen',
781780 'nohistory' => 'Es gibt keine früheren Versionen dieser Seite.',
782781 'revnotfound' => 'Diese Version wurde nicht gefunden.',
Index: trunk/phase3/RELEASE-NOTES
@@ -211,8 +211,8 @@
212212 * Graceful behavior for updateRestrictions.php if a page already has records
213213 in the page_restrictions matching its old page_restrictions field.
214214 May help with odd upgrade issues or race condition.
 215+* (bug 11993) Remove contentsub "revision history"
215216
216 -
217217 == Parser changes in 1.12 ==
218218
219219 The parser pass order has changed from

Follow-up revisions

RevisionCommit summaryAuthorDate
r28150Housekeeping for r28137.raymond18:33, 4 December 2007

Status & tagging log