r26189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26188‎ | r26189 | r26190 >
Date:20:43, 27 September 2007
Author:vyznev
Status:old
Tags:
Comment:
If the page doesn't exist and the user can't create it, omit the "edit"/"view source"
tab entirely (since the user can't edit and there's no source to view).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -685,7 +685,7 @@
686686 'href' => $this->mTitle->getLocalUrl( 'action=edit&section=new' )
687687 );
688688 }
689 - } else {
 689+ } elseif ( $this->mTitle->exists() ) {
690690 $content_actions['viewsource'] = array(
691691 'class' => ($action == 'edit') ? 'selected' : false,
692692 'text' => wfMsg('viewsource'),
Index: trunk/phase3/RELEASE-NOTES
@@ -30,6 +30,8 @@
3131 * (bug 5412) Add feed links for the site to all pages
3232 * (bug 11353) Add ability to retrieve raw section content via action=raw
3333 * Show relevant deletion log lines when uploading a previously deleted file
 34+* On SkinTemplate based skins (like MonoBook), omit confusing "edit"/"view source"
 35+ tab entirely if the page doesn't exist and the user isn't allowed to create it
3436
3537 === Bug fixes in 1.12 ===
3638

Follow-up revisions

RevisionCommit summaryAuthorDate
r26190fix minor regression in r26189: users should be able to view the source of de...vyznev20:52, 27 September 2007
r26257Merged revisions 26134-26247 via svnmerge from...david19:06, 30 September 2007

Status & tagging log