r25863 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25862‎ | r25863 | r25864 >
Date:20:53, 14 September 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 11342) Fix several 'returnto' links in permissions/error pages which
linked to the main page instead of targetted page
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2025,7 +2025,7 @@
20262026 <input type='hidden' name='wpEditToken' value=\"{$token}\" />
20272027 </form>\n" );
20282028
2029 - $wgOut->returnToMain( false );
 2029+ $wgOut->returnToMain( false, $this->mTitle );
20302030
20312031 $this->showLogExtract( $wgOut );
20322032 }
Index: trunk/phase3/includes/SpecialUserlogin.php
@@ -189,7 +189,7 @@
190190 $wgOut->setArticleRelated( false );
191191 $wgOut->setRobotPolicy( 'noindex,nofollow' );
192192 $wgOut->addHtml( wfMsgWikiHtml( 'accountcreatedtext', $u->getName() ) );
193 - $wgOut->returnToMain( $self->getPrefixedText() );
 193+ $wgOut->returnToMain( false, $self );
194194 wfRunHooks( 'AddNewAccount', array( $u ) );
195195 return true;
196196 }
Index: trunk/phase3/includes/EditPage.php
@@ -1494,7 +1494,7 @@
14951495 $wgOut->setArticleRelated( false );
14961496
14971497 $wgOut->addHtml( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
1498 - $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
 1498+ $wgOut->returnToMain( false, $this->mTitle );
14991499 }
15001500
15011501 /**
@@ -1510,7 +1510,7 @@
15111511 $wgOut->setArticleRelated( false );
15121512
15131513 $wgOut->addWikiText( wfMsg( 'confirmedittext' ) );
1514 - $wgOut->returnToMain( false );
 1514+ $wgOut->returnToMain( false, $this->mTitle );
15151515 }
15161516
15171517 /**
@@ -1525,7 +1525,7 @@
15261526 $wgOut->setArticleRelated( false );
15271527
15281528 $wgOut->addWikiText( wfMsg( 'nosuchsectiontext', $this->section ) );
1529 - $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
 1529+ $wgOut->returnToMain( false, $this->mTitle );
15301530 }
15311531
15321532 /**
@@ -1544,7 +1544,7 @@
15451545 if ( $match )
15461546 $wgOut->addWikiText( wfMsg( 'spamprotectionmatch', "<nowiki>{$match}</nowiki>" ) );
15471547
1548 - $wgOut->returnToMain( false );
 1548+ $wgOut->returnToMain( false, $this->mTitle );
15491549 }
15501550
15511551 /**
Index: trunk/phase3/includes/OutputPage.php
@@ -1060,7 +1060,7 @@
10611061 $article = new Article( $wgTitle );
10621062 $this->addHTML( $skin->formatTemplates( $article->getUsedTemplates() ) );
10631063
1064 - $this->returnToMain( false );
 1064+ $this->returnToMain( false, $wgTitle );
10651065 }
10661066
10671067 /** @deprecated */
Index: trunk/phase3/RELEASE-NOTES
@@ -54,7 +54,10 @@
5555 * (bug 11321) Fix width of gallerybox when option "width=xxx" is used
5656 * (bug 7890) Special:BrokenRedirects links deleted redirects to a non-existent page
5757 * Fix initial statistics when installing: add correct values
 58+* (bug 11342) Fix several 'returnto' links in permissions/error pages which
 59+ linked to the main page instead of targetted page
5860
 61+
5962 === API changes in 1.12 ===
6063
6164 Full API documentation is available at http://www.mediawiki.org/wiki/API

Follow-up revisions

RevisionCommit summaryAuthorDate
r25932Merged revisions 25861-25931 via svnmerge from...david06:43, 19 September 2007

Status & tagging log