r25819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25818‎ | r25819 | r25820 >
Date:18:36, 12 September 2007
Author:raymond
Status:old
Tags:
Comment:
* (bug 11243) Show thumbnail on image description page previews
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1424,7 +1424,18 @@
14251425 wfProfileOut( $fname );
14261426 return $previewhead;
14271427 } else {
1428 - $toparse = $this->textbox1;
 1428+ # If an image description page is edited, show a thumbnail at time of edit preview
 1429+ # <gallery> format used as it handles all non image files (.ogg, .pdf, ...) very nice.
 1430+ if ( $wgTitle->mNamespace == NS_IMAGE ) {
 1431+ global $wgContLang;
 1432+ $align = $wgContLang->isRtl() ? 'left' : 'right';
 1433+ $imageLink = "<div class=\"mw-image-edit-preview\" style=\"float:$align\"><gallery>" .
 1434+ $wgTitle->mPrefixedText. "|" . $wgTitle->mPrefixedText .
 1435+ "</gallery></div>\n";
 1436+ $toparse = $imageLink . $this->textbox1;
 1437+ } else {
 1438+ $toparse = $this->textbox1;
 1439+ }
14291440
14301441 # If we're adding a comment, we need to show the
14311442 # summary as the headline
@@ -2086,5 +2097,3 @@
20872098 }
20882099
20892100 }
2090 -
2091 -
Index: trunk/phase3/RELEASE-NOTES
@@ -22,6 +22,7 @@
2323
2424 === New features in 1.12 ===
2525 * Add a warning for non-descriptive filenames at Special:Upload
 26+* (bug 11243) Show thumbnail on image description page previews
2627
2728 === Bug fixes in 1.12 ===
2829

Follow-up revisions

RevisionCommit summaryAuthorDate
r25831Revert r25819 -- Adding a floated gallery to image description page previews ...brion18:35, 13 September 2007
r25849Merged revisions 25804-25848 via svnmerge from...david06:54, 14 September 2007

Status & tagging log