r25802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25801‎ | r25802 | r25803 >
Date:22:47, 11 September 2007
Author:amidaniel
Status:old
Tags:
Comment:
(API) Partial revert of r25742. Escaping all html special characters in the output breaks links that have these special characters in them.
Modified paths:
  • /trunk/phase3/includes/api/ApiFormatBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFormatBase.php
@@ -158,8 +158,6 @@
159159 * This method also replaces any '<' with &lt;
160160 */
161161 protected function formatHTML($text) {
162 - // Escape everything first for full coverage
163 - $text = htmlspecialchars($text);
164162
165163 // encode all comments or tags as safe blue strings
166164 $text = preg_replace('/\&lt;(!--.*?--|.*?)\&gt;/', '<span style="color:blue;">&lt;\1&gt;</span>', $text);

Follow-up revisions

RevisionCommit summaryAuthorDate
r25804Merged revisions 25752-25803 via svnmerge from...david02:25, 12 September 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25742* (bug 11158) Fix escaping in API HTML-formatted JSONbrion21:01, 10 September 2007

Status & tagging log