r25791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25790‎ | r25791 | r25792 >
Date:17:38, 11 September 2007
Author:brion
Status:old
Tags:
Comment:
Poke about with spacing in the contribs form... It still feels busy to me, but adjusts some wrapping issues.
* Space now present between 'Namespace:' label and selector drop-down
* Added no-wrap spans wrapping label and control for the namespace, year,
and month selectors, so the form is more legible at smaller window sizes where the long lines don't make it through intact
Modified paths:
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialContributions.php
@@ -426,13 +426,20 @@
427427 Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parseinline' ) ), 'contribs' , 'newbie' , 'newbie', $options['contribs'] == 'newbie' ? true : false ) . '<br />' .
428428 Xml::radioLabel( wfMsgExt( 'sp-contributions-username', array( 'parseinline' ) ), 'contribs' , 'user', 'user', $options['contribs'] == 'user' ? true : false ) . ' ' .
429429 Xml::input( 'target', 20, $options['target']) . ' '.
430 - Xml::label( wfMsg( 'namespace' ), 'namespace' ) .
 430+ '<span style="white-space: nowrap">' .
 431+ Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
431432 Xml::namespaceSelector( $options['namespace'], '' ) .
 433+ '</span>' .
432434 Xml::openElement( 'p' ) .
 435+ '<span style="white-space: nowrap">' .
433436 Xml::label( wfMsg( 'year' ), 'year' ) . ' '.
434 - Xml::input( 'year', 4, $options['year'], array('id' => 'year', 'maxlength' => 4) ) . ' '.
 437+ Xml::input( 'year', 4, $options['year'], array('id' => 'year', 'maxlength' => 4) ) .
 438+ '</span>' .
 439+ ' '.
 440+ '<span style="white-space: nowrap">' .
435441 Xml::label( wfMsg( 'month' ), 'month' ) . ' '.
436442 Xml::monthSelector( $options['month'], -1 ) . ' '.
 443+ '</span>' .
437444 Xml::submitButton( wfMsg( 'sp-contributions-submit' ) ) .
438445 Xml::closeElement( 'p' );
439446

Follow-up revisions

RevisionCommit summaryAuthorDate
r25804Merged revisions 25752-25803 via svnmerge from...david02:25, 12 September 2007

Status & tagging log