r25669 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25668‎ | r25669 | r25670 >
Date:18:54, 8 September 2007
Author:brion
Status:old
Tags:
Comment:
Use $wgStylePath, not $wgScriptPath/skins, so it actually works on installations such as our own :)
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -192,8 +192,8 @@
193193 $height = empty( $params['height'] ) ? 20 : $params['height'];
194194 if ( $noPlayer ) {
195195 if ( $height > 100 ) {
196 - global $wgScriptPath;
197 - $iconUrl = "$wgScriptPath/skins/common/images/icons/fileicon-ogg.png";
 196+ global $wgStylePath;
 197+ $iconUrl = "$wgStylePath/common/images/icons/fileicon-ogg.png";
198198 return new ThumbnailImage( $file, $iconUrl, 120, 120 );
199199 } else {
200200 $scriptPath = self::getMyScriptPath();
@@ -498,9 +498,9 @@
499499 // Sound file
500500 if ( $height > 100 ) {
501501 // Use a big file icon
502 - global $wgScriptPath;
 502+ global $wgStylePath;
503503 $imgAttribs = array(
504 - 'src' => "$wgScriptPath/skins/common/images/icons/fileicon-ogg.png",
 504+ 'src' => "$wgStylePath/common/images/icons/fileicon-ogg.png",
505505 'width' => 125,
506506 'height' => 125,
507507 );

Status & tagging log