r25427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25426‎ | r25427 | r25428 >
Date:08:35, 3 September 2007
Author:ilabarg1
Status:old
Tags:
Comment:
[EditPage.php]-AS_SUMMARY_NEEDED_A&B are put together as same constant error (AS_SUMMARY_NEEDED).
Modified paths:
  • /branches/ApiEdit_Vodafone/includes/EditPage.php (modified) (history)

Diff [purge]

Index: branches/ApiEdit_Vodafone/includes/EditPage.php
@@ -28,8 +28,7 @@
2929 const AS_NO_CREATE_PERMISSION = 223;
3030 const AS_BLANK_ARTICLE = 224;
3131 const AS_CONFLICT_DETECTED = 225;
32 - const AS_SUMMARY_NEEDED_A = 226;
33 - const AS_SUMMARY_NEEDED_B = 227;
 32+ const AS_SUMMARY_NEEDED = 226;
3433 const AS_TEXTBOX_EMPTY = 228;
3534 const AS_MAX_ARTICLE_SIZE_EXCEDED = 229;
3635 const AS_OK = 230;
@@ -858,7 +857,7 @@
859858 if( md5( $this->summary ) == $this->autoSumm ) {
860859 $this->missingSummary = true;
861860 wfProfileOut( $fname );
862 - return self::AS_SUMMARY_NEEDED_A;
 861+ return self::AS_SUMMARY_NEEDED;
863862 // return( true );
864863 }
865864 }
@@ -868,7 +867,7 @@
869868 if (trim($this->summary) == '') {
870869 $this->missingSummary = true;
871870 wfProfileOut( $fname );
872 - return self::AS_SUMMARY_NEEDED_B;
 871+ return self::AS_SUMMARY_NEEDED;
873872 // return( true );
874873 }
875874 }
@@ -2143,12 +2142,9 @@
21442143 case self::AS_TEXTBOX_EMPTY:
21452144 return true;
21462145
2147 - case self::AS_SUMMARY_NEEDED_B:
 2146+ case self::AS_SUMMARY_NEEDED:
21482147 return true;
21492148
2150 - case self::AS_SUMMARY_NEEDED_A:
2151 - return true;
2152 -
21532149 case self::AS_CONFLICT_DETECTED:
21542150 return true;
21552151

Status & tagging log