r25351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25350‎ | r25351 | r25352 >
Date:12:38, 31 August 2007
Author:aaron
Status:old
Tags:
Comment:
*Add $wgExtPGNewFields. Allowing for extensions to use only $wgExtNewFields when PG/mysql updaters use different formats (column attributes vs directory to query file) is just asking for mistakes to be made.
Modified paths:
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updaters.inc
@@ -89,6 +89,7 @@
9090 # $wgDBtype should be checked to specifiy the proper file
9191 $wgExtNewTables = array(); // table, dir
9292 $wgExtNewFields = array(); // table, column, dir
 93+$wgExtPGNewFields = array(); // table, column attributes; for PostgreSQL
9394 $wgExtNewIndexes = array(); // table, index, dir
9495
9596 function rename_table( $from, $to, $patch ) {
@@ -1497,7 +1498,7 @@
14981499 } else
14991500 echo "... archive.ar_deleted already exists\n";
15001501
1501 - global $wgExtNewTables, $wgExtNewFields, $wgExtNewIndexes;
 1502+ global $wgExtNewTables, $wgExtPGNewFields, $wgExtNewIndexes;
15021503 # Add missing extension tables
15031504 foreach ( $wgExtNewTables as $nt ) {
15041505 if ($wgDatabase->tableExists($nt[0])) {
@@ -1509,7 +1510,7 @@
15101511 dbsource($nt[1]);
15111512 }
15121513 # Add missing extension fields
1513 - foreach ( $wgExtNewFields as $nc ) {
 1514+ foreach ( $wgExtPGNewFields as $nc ) {
15141515 $fi = $wgDatabase->fieldInfo($nc[0], $nc[1]);
15151516 if (!is_null($fi)) {
15161517 echo "... column $nc[0].$nc[1] already exists\n";

Follow-up revisions

RevisionCommit summaryAuthorDate
r25372Merged revisions 25338-25371 via svnmerge from...david18:18, 31 August 2007

Status & tagging log