r25200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25199‎ | r25200 | r25201 >
Date:16:01, 27 August 2007
Author:raymond
Status:old
Tags:
Comment:
Remove 'blockedtext-concise'/'autoblockedtext-concise' messages, they are redundant to 'blockedtext/'autoblockedtext'
I do not see a reason why to maintain four very very similar messages instead of two messages.
Add $blockTimestamp as $8. It's used in OutputPage.php for these messages too.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -458,8 +458,6 @@
459459 'blockedtitle',
460460 'blockedtext',
461461 'autoblockedtext',
462 - 'blockedtext-concise',
463 - 'autoblockedtext-concise',
464462 'blockedoriginalsource',
465463 'blockededitsource',
466464 'whitelistedittitle',
Index: trunk/phase3/includes/Title.php
@@ -1066,6 +1066,7 @@
10671067 $link = '[[' . $wgContLang->getNsText( NS_USER ) . ":{$name}|{$name}]]";
10681068 $blockid = $block->mId;
10691069 $blockExpiry = $user->mBlock->mExpiry;
 1070+ $blockTimestamp = $wgLang->timeanddate( wfTimestamp( TS_MW, $wgUser->mBlock->mTimestamp ), true );
10701071
10711072 if ( $blockExpiry == 'infinity' ) {
10721073 // Entry in database (table ipblocks) is 'infinity' but 'ipboptions' uses 'infinite' or 'indefinite'
@@ -1088,7 +1089,7 @@
10891090
10901091 $intended = $user->mBlock->mAddress;
10911092
1092 - $errors[] = array ( ($block->mAuto ? 'autoblockedtext-concise' : 'blockedtext-concise'), $link, $reason, $ip, $name, $blockid, $blockExpiry, $intended );
 1093+ $errors[] = array ( ($block->mAuto ? 'autoblockedtext' : 'blockedtext'), $link, $reason, $ip, $name, $blockid, $blockExpiry, $intended, $blockTimestamp );
10931094 }
10941095
10951096 return $errors;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -979,12 +979,6 @@
980980 registered in your [[Special:Preferences|user preferences]] and you have not been blocked from using it.
981981
982982 Your block ID is $5. Please include this ID in any queries you make.',
983 -'blockedtext-concise' => "$7, which matches your username or IP address, has been blocked by $1. The reason given was $2. The expiry time of this block is $6. To discuss the block, you can
984 -contact $1, or another administrator. You cannot use the 'email this user' feature unless a valid email address is specified in your account preferences and you have not been blocked from using it.
985 -Your current IP address is $3, and the block ID is #$5. Please include either or both of these in any queries.",
986 -'autoblockedtext-concise' => "Your IP address has recently been used by a user who was blocked. The block was made by $1. The reason given was $2. The expiry time of this block is $6. To
987 -discuss the block, you can contact $1, or another administrator. You cannot use the 'email this user' feature unless a valid email address is specified in your account preferences and you have not
988 -been blocked from using it. Your current IP address is $3, and the block ID is #$5. Please include either or both of these in any queries.",
989983 'blockedoriginalsource' => "The source of '''$1''' is
990984 shown below:",
991985 'blockededitsource' => "The text of '''your edits''' to '''$1''' is shown below:",

Follow-up revisions

RevisionCommit summaryAuthorDate
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Status & tagging log