r24944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24943‎ | r24944 | r24945 >
Date:13:13, 20 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 11001) Submit Special:Newpages as a GET, rather than a POST request
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialNewpages.php
@@ -138,8 +138,10 @@
139139 * @return string
140140 */
141141 function getPageHeader() {
 142+ global $wgScript;
142143 $self = SpecialPage::getTitleFor( $this->getName() );
143 - $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $self->getLocalUrl() ) );
 144+ $form = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
 145+ $form .= Xml::hidden( 'title', $self->getPrefixedUrl() );
144146 # Namespace selector
145147 $form .= '<table><tr><td align="right">' . Xml::label( wfMsg( 'namespace' ), 'namespace' ) . '</td>';
146148 $form .= '<td>' . Xml::namespaceSelector( $this->namespace, 'all' ) . '</td></tr>';
Index: trunk/phase3/RELEASE-NOTES
@@ -179,6 +179,7 @@
180180 information
181181 * Confirmation is now required when deleting old versions of files
182182 * (bug 7535) Users can now enter comments when deleting old versions of files
 183+* (bug 11001) Submit Special:Newpages as a GET, rather than a POST request
183184
184185 == Bugfixes since 1.10 ==
185186

Follow-up revisions

RevisionCommit summaryAuthorDate
r25016Merged revisions 24866-25015 via svnmerge from...david23:06, 21 August 2007

Status & tagging log