r24823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24822‎ | r24823 | r24824 >
Date:15:32, 15 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Language::lc() is non-static
Modified paths:
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -148,10 +148,14 @@
149149
150150 /** Callback to sort extensions by type */
151151 function compare( $a, $b ) {
152 - if ( $a['name'] === $b['name'] )
 152+ global $wgLang;
 153+ if( $a['name'] === $b['name'] ) {
153154 return 0;
154 - else
155 - return Language::lc( $a['name'] ) > Language::lc( $b['name'] ) ? 1 : -1;
 155+ } else {
 156+ return $wgLang->lc( $a['name'] ) > $wgLang->lc( $b['name'] )
 157+ ? 1
 158+ : -1;
 159+ }
156160 }
157161
158162 function formatCredits( $name, $version = null, $author = null, $url = null, $description = null) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Status & tagging log