r24677 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24676‎ | r24677 | r24678 >
Date:17:29, 8 August 2007
Author:yaron
Status:old
Tags:
Comment:
Fix for fencepost error introduced in last version
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc
@@ -152,6 +152,11 @@
153153 if (($i == strlen($existing_template_text) - 1) ||
154154 ($c == '|' && $uncompleted_square_brackets == 0)) {
155155 if ($field != null) {
 156+ // if this was the last character in the template, append
 157+ // this character
 158+ if ($i == strlen($existing_template_text) - 1) {
 159+ $field .= $c;
 160+ }
156161 // either there's an equals sign near the beginning or not -
157162 // handling is similar in either way; if there's no equals
158163 // sign, the index of this field becomes the key

Status & tagging log