r24614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24613‎ | r24614 | r24615 >
Date:07:21, 6 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Miscellaneous aesthetic improvements to Special:Ipblocklist
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialIpblocklist.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1337,6 +1337,8 @@
13381338 'unblocked',
13391339 'unblocked-id',
13401340 'ipblocklist',
 1341+ 'ipblocklist-legend',
 1342+ 'ipblocklist-username',
13411343 'ipblocklist-summary',
13421344 'ipblocklist-submit',
13431345 'blocklistline',
Index: trunk/phase3/includes/SpecialIpblocklist.php
@@ -245,8 +245,11 @@
246246 return
247247 Xml::tags( 'form', array( 'action' => $wgScript ),
248248 Xml::hidden( 'title', $wgTitle->getPrefixedDbKey() ) .
249 - Xml::input( 'ip', /*size*/ false, $this->ip ) .
250 - Xml::submitButton( wfMsg( 'ipblocklist-submit' ) )
 249+ Xml::openElement( 'fieldset' ) .
 250+ Xml::element( 'legend', null, wfMsg( 'ipblocklist-legend' ) ) .
 251+ Xml::inputLabel( wfMsg( 'ipblocklist-username' ), 'ip', 'ip', /* size */ false, $this->ip ) .
 252+ Xml::submitButton( wfMsg( 'ipblocklist-submit' ) ) .
 253+ Xml::closeElement( 'fieldset' )
251254 );
252255 }
253256
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2018,6 +2018,8 @@
20192019 'unblocked' => '[[User:$1|$1]] has been unblocked',
20202020 'unblocked-id' => 'Block $1 has been removed',
20212021 'ipblocklist' => 'List of blocked IP addresses and usernames',
 2022+'ipblocklist-legend' => 'Find a blocked user',
 2023+'ipblocklist-username' => 'Username or IP address:',
20222024 'ipblocklist-summary' => '', # only translate this message to other languages if you have to change it
20232025 'ipblocklist-submit' => 'Search',
20242026 'blocklistline' => '$1, $2 blocked $3 ($4)',
Index: trunk/phase3/RELEASE-NOTES
@@ -166,6 +166,9 @@
167167 Special:Protectedpages (implicit protection, doesn't make sense to have it)
168168 * (bug 10793) "Mark patrolled" links will now be shown for users with
169169 patrol permissions on all eligible diff pages
 170+* (bug 10655) Show standard tool links for blocked users in block log messages
 171+* Show standard tool links for blocked users in Special:Ipblocklist
 172+* Miscellaneous aesthetic improvements to Special:Ipblocklist
170173
171174 == Bugfixes since 1.10 ==
172175
@@ -359,8 +362,6 @@
360363 * (bug 10765) img_auth.php will now refuse logged-out requests where
361364 $wgWhitelistRead is undefined, instead of (incorrectly) honouring them
362365 * Fixed img_auth.php file name extraction for whitelist checking
363 -* (bug 10655) Show standard tool links for blocked users in block log messages
364 -* Show standard tool links for blocked users in Special:Ipblocklist
365366
366367 == API changes since 1.10 ==
367368

Follow-up revisions

RevisionCommit summaryAuthorDate
r24632Merged revisions 24601-24631 via svnmerge from...david18:44, 6 August 2007

Status & tagging log