r24613 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24612‎ | r24613 | r24614 >
Date:07:14, 6 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Errant escaping of titles
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -155,7 +155,7 @@
156156 switch( $type ) {
157157 case 'move':
158158 $titleLink = $skin->makeLinkObj( $title, $title->getPrefixedText(), 'redirect=no' );
159 - $params[0] = $skin->makeLinkObj( Title::newFromText( $params[0] ), $params[0] );
 159+ $params[0] = $skin->makeLinkObj( Title::newFromText( $params[0] ), htmlspecialchars( $params[0] ) );
160160 break;
161161 case 'block':
162162 if( substr( $title->getText(), 0, 1 ) == '#' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24632Merged revisions 24601-24631 via svnmerge from...david18:44, 6 August 2007

Status & tagging log