r24476 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24475‎ | r24476 | r24477 >
Date:21:09, 30 July 2007
Author:raymond
Status:old
Tags:
Comment:
* Prettifying file history table a bit. Especially for histories with long comments/descriptions it look clearer now.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -31,10 +31,21 @@
3232 /**
3333 * File histories
3434 */
 35+table.filehistory {
 36+ border:1px solid #ccc;
 37+ border-collapse:collapse;
 38+}
 39+
3540 table.filehistory th,
3641 table.filehistory td {
3742 padding: 0 0.2em 0 0.2em;
 43+ vertical-align:top;
 44+ border:1px solid #ccc;
3845 }
3946 table.filehistory th {
4047 text-align: left;
41 -}
\ No newline at end of file
 48+}
 49+table.filehistory td.mw-imagepage-filesize,
 50+table.filehistory th.mw-imagepage-filesize {
 51+ white-space:nowrap;
 52+}
Index: trunk/phase3/includes/ImagePage.php
@@ -673,7 +673,7 @@
674674 . '<th>' . wfMsgHtml( 'filehist-datetime' ) . '</th>'
675675 . '<th>' . wfMsgHtml( 'filehist-user' ) . '</th>'
676676 . '<th>' . wfMsgHtml( 'filehist-dimensions' ) . '</th>'
677 - . '<th>' . wfMsgHtml( 'filehist-filesize' ) . '</th>'
 677+ . '<th class="mw-imagepage-filesize">' . wfMsgHtml( 'filehist-filesize' ) . '</th>'
678678 . '<th>' . wfMsgHtml( 'filehist-comment' ) . '</th>'
679679 . "</tr>\n";
680680 }
@@ -686,7 +686,7 @@
687687 global $wgUser, $wgLang, $wgTitle, $wgContLang;
688688 $local = $this->img->isLocal();
689689 $row = '';
690 -
 690+
691691 // Deletion link
692692 if( $local && $wgUser->isAllowed( 'delete' ) ) {
693693 $row .= '<td>';
@@ -702,7 +702,7 @@
703703 ) . ')';
704704 $row .= '</td>';
705705 }
706 -
 706+
707707 // Reversion link/current indicator
708708 $row .= '<td>';
709709 if( $iscur ) {
@@ -719,7 +719,7 @@
720720 ) . ')';
721721 }
722722 $row .= '</td>';
723 -
 723+
724724 // Date/time and image link
725725 $row .= '<td>';
726726 $url = $iscur ? $this->img->getUrl() : $this->img->getArchiveUrl( $img );
@@ -729,7 +729,7 @@
730730 $wgLang->timeAndDate( $timestamp, true )
731731 );
732732 $row .= '</td>';
733 -
 733+
734734 // Uploading user
735735 $row .= '<td>';
736736 if( $local ) {
@@ -738,19 +738,19 @@
739739 $row .= htmlspecialchars( $usertext );
740740 }
741741 $row .= '</td>';
742 -
 742+
743743 // Image dimensions
744744 // FIXME: It would be nice to show the duration (sound files) or
745745 // width/height/duration (video files) here, but this needs some
746746 // additional media handler work
747747 $row .= '<td>' . wfMsgHtml( 'widthheight', $width, $height ) . '</td>';
748 -
 748+
749749 // File size
750 - $row .= '<td>' . $this->skin->formatSize( $size ) . '</td>';
751 -
 750+ $row .= '<td class="mw-imagepage-filesize">' . $this->skin->formatSize( $size ) . '</td>';
 751+
752752 // Comment
753753 $row .= '<td>' . $this->skin->formatComment( $description, $this->title ) . '</td>';
754 -
 754+
755755 return "<tr>{$row}</tr>\n";
756756 }
757757
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1195,7 +1195,7 @@
11961196 * to ensure that client-side caches don't keep obsolete copies of global
11971197 * styles.
11981198 */
1199 -$wgStyleVersion = '93';
 1199+$wgStyleVersion = '94';
12001200
12011201
12021202 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r24502Merged revisions 24415-24479 via svnmerge from...david22:31, 31 July 2007

Status & tagging log