r24229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24228‎ | r24229 | r24230 >
Date:07:18, 18 July 2007
Author:robchurch
Status:old
Tags:
Comment:
Clean up and update documentation for Title::isAlwaysKnown()
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2474,16 +2474,15 @@
24752475 }
24762476
24772477 /**
2478 - * Should a link should be displayed as a known link, just based on its title?
 2478+ * Do we know that this title definitely exists, or should we otherwise
 2479+ * consider that it exists?
24792480 *
2480 - * Currently, a self-link with a fragment and special pages are in
2481 - * this category. System messages that have defined default values are also
2482 - * always known.
 2481+ * @return bool
24832482 */
24842483 public function isAlwaysKnown() {
2485 - return ( $this->isExternal() ||
2486 - ( 0 == $this->mNamespace && "" == $this->mDbkeyform ) ||
2487 - ( NS_MEDIAWIKI == $this->mNamespace && wfMsgWeirdKey( $this->mDbkeyform ) ) );
 2484+ return $this->isExternal()
 2485+ || ( $this->mNamespace == NS_MAIN && $this->mDbkeyform == '' )
 2486+ || ( $this->mNamespace == NS_MEDIAWIKI && wfMsgWeirdKey( $this->mDbkeyform ) );
24882487 }
24892488
24902489 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r24276Merged revisions 24213-24275 via svnmerge from...david20:20, 19 July 2007

Status & tagging log