r24216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24215‎ | r24216 | r24217 >
Date:22:30, 17 July 2007
Author:robchurch
Status:old
Tags:
Comment:
Pass the user as an argument to 'isValidPassword' hook callbacks; see docs/hooks.txt for more information
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -467,6 +467,7 @@
468468 'isValidPassword': Override the result of User::isValidPassword()
469469 $password: Desired password
470470 &$result: Set this and return false to override the internal checks
 471+$user: User the password is being validated for
471472
472473 'LoginAuthenticateAudit': a login attempt for a valid user account either succeeded or failed.
473474 No return data is accepted; this hook is for auditing only.
Index: trunk/phase3/includes/User.php
@@ -490,7 +490,7 @@
491491 global $wgMinimalPasswordLength, $wgContLang;
492492
493493 $result = null;
494 - if( !wfRunHooks( 'isValidPassword', array( $password, &$result ) ) )
 494+ if( !wfRunHooks( 'isValidPassword', array( $password, &$result, $this ) ) )
495495 return $result;
496496 if( $result === false )
497497 return false;
Index: trunk/phase3/RELEASE-NOTES
@@ -150,6 +150,8 @@
151151 phisticated handheld browser.
152152 * (bug 3173) Option to offer exported pages as a download, rather than displaying
153153 inline, as in most browsers
 154+* Pass the user as an argument to 'isValidPassword' hook callbacks; see
 155+ docs/hooks.txt for more information
154156
155157 == Bugfixes since 1.10 ==
156158

Follow-up revisions

RevisionCommit summaryAuthorDate
r24276Merged revisions 24213-24275 via svnmerge from...david20:20, 19 July 2007

Status & tagging log