r24181 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24180‎ | r24181 | r24182 >
Date:21:28, 16 July 2007
Author:greg
Status:old
Tags:
Comment:
Fix bug 10608, plus a bonus one that was hidden by that bug.
Modified paths:
  • /trunk/phase3/includes/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DatabasePostgres.php
@@ -1016,7 +1016,7 @@
10171017 ."WHERE n.nspowner=r.oid AND n.nspname = '$eschema'";
10181018 $res = $this->query( $SQL );
10191019 if ( $res && $res->numRows() ) {
1020 - $row = $res->fetchRow();
 1020+ $row = $res->fetchObject();
10211021 $owner = $row->rolname;
10221022 } else {
10231023 $owner = false;
@@ -1104,8 +1104,7 @@
11051105 $tss = $this->addQuotes($wgDBts2schema);
11061106 $pgp = $this->addQuotes($wgDBport);
11071107 $dbn = $this->addQuotes($this->mDBname);
1108 - $ctypeRow = $this->doQuery("SHOW lc_ctype")->fetchArray();
1109 - $ctype = $ctypeRow[0];
 1108+ $ctype = pg_fetch_result($this->doQuery("SHOW lc_ctype"),0,0);
11101109
11111110 $SQL = "UPDATE mediawiki_version SET mw_version=$mwv, pg_version=$pgv, pg_user=$pgu, ".
11121111 "mw_schema = $mws, ts2_schema = $tss, pg_port=$pgp, pg_dbname=$dbn, ".

Follow-up revisions

RevisionCommit summaryAuthorDate
r24182Mention bug fix from r24181 in release notes; if the "other bug" is worth men...robchurch22:40, 16 July 2007
r24215Merged revisions 24095-24212 via svnmerge from...david21:19, 17 July 2007

Status & tagging log