r24036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24035‎ | r24036 | r24037 >
Date:15:50, 12 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Removed special properties "IS_SUBRELATION_OF" and "IS_SUBATTRIBUTE_OF" in favour of "SUBPROPOERTY_OF".
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageDe.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageEn.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageEs.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageFr.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageHe.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguagePl.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageRu.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageSk.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/ExportRDF/SMW_SpecialExportRDF.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/ExportRDF/SMW_SpecialExportRDF.php
@@ -661,7 +661,7 @@
662662
663663 // add rdfs:subPropertyOf statements
664664 if ($subrel_rel) {
665 - $relations = &smwfGetStore()->getSpecialValues($et->title, SMW_SP_IS_SUBRELATION_OF);
 665+ $relations = &smwfGetStore()->getSpecialValues($et->title, SMW_SP_SUBPROPERTY_OF);
666666 foreach ($relations as $relation) {
667667 // TODO in future, check type safety relations <-> attributes
668668 // TODO check also the type of what I am pointing to (is it a relation or sth else?)
@@ -673,7 +673,7 @@
674674 }
675675 }
676676 if ($subatt_rel) {
677 - $attributes = &smwfGetStore()->getSpecialValues($et->title, SMW_SP_IS_SUBATTRIBUTE_OF);
 677+ $attributes = &smwfGetStore()->getSpecialValues($et->title, SMW_SP_SUBPROPERTY_OF);
678678 foreach ($attributes as $attribute) {
679679 // TODO in future, check type safety relations <-> attributes
680680 // TODO check also the type of what I am pointing to (is it an atrribute or sth else?)
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php
@@ -9,8 +9,8 @@
1010 define('SMW_SP_HAS_TYPE',1);
1111 define('SMW_SP_HAS_URI',2);
1212 define('SMW_SP_HAS_CATEGORY',4);
13 -define('SMW_SP_IS_SUBRELATION_OF',3);
14 -define('SMW_SP_IS_SUBATTRIBUTE_OF',5);
 13+//define('SMW_SP_IS_SUBRELATION_OF',3); // no longer used
 14+//define('SMW_SP_IS_SUBATTRIBUTE_OF',5); // no longer used
1515 define('SMW_SP_MAIN_DISPLAY_UNIT', 6);
1616 define('SMW_SP_DISPLAY_UNIT', 7);
1717 define('SMW_SP_IMPORTED_FROM',8);
@@ -22,6 +22,7 @@
2323 define('SMW_SP_POSSIBLE_VALUE', 14);
2424 define('SMW_SP_REDIRECTS_TO', 15);
2525 define('SMW_SP_CONVERSION_FACTOR_SI', 16);
 26+define('SMW_SP_SUBPROPERTY_OF',17);
2627
2728 // constants for displaying the factbox
2829 define('SMW_FACTBOX_HIDDEN', 1);
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageEn.php
@@ -225,8 +225,7 @@
226226 //always start upper-case
227227 SMW_SP_HAS_TYPE => 'Has type',
228228 SMW_SP_HAS_URI => 'Equivalent URI',
229 - SMW_SP_IS_SUBRELATION_OF => 'Is subrelation of',
230 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Is subattribute of',
 229+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of',
231230 SMW_SP_MAIN_DISPLAY_UNIT => 'Main display unit',
232231 SMW_SP_DISPLAY_UNIT => 'Display unit',
233232 SMW_SP_IMPORTED_FROM => 'Imported from',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageRu.php
@@ -200,8 +200,7 @@
201201 //always start upper-case
202202 SMW_SP_HAS_TYPE => 'Имеет тип',
203203 SMW_SP_HAS_URI => 'Эквивалентный URI',
204 - SMW_SP_IS_SUBRELATION_OF => 'Является подчиненным отношением для',
205 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Является подчиненным атрибутом для',
 204+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
206205 SMW_SP_MAIN_DISPLAY_UNIT => 'Основная отображаемая единица',
207206 SMW_SP_DISPLAY_UNIT => 'Отображаемая единица',
208207 SMW_SP_IMPORTED_FROM => 'Импортировано из',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageEs.php
@@ -209,8 +209,7 @@
210210 //always start upper-case
211211 SMW_SP_HAS_TYPE => 'Tiene tipo de datos',
212212 SMW_SP_HAS_URI => 'URI equivalente',
213 - SMW_SP_IS_SUBRELATION_OF => 'Es una subrelación de',
214 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Es un subatributo de',
 213+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
215214 SMW_SP_MAIN_DISPLAY_UNIT => 'Unidad de medida principal para la visualización',
216215 SMW_SP_DISPLAY_UNIT => 'Unidad de medida',
217216 SMW_SP_IMPORTED_FROM => 'Importado de',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageFr.php
@@ -210,8 +210,7 @@
211211 //always start upper-case
212212 SMW_SP_HAS_TYPE => 'A le type',
213213 SMW_SP_HAS_URI => 'URI équivalente',
214 - SMW_SP_IS_SUBRELATION_OF => 'Est une sous-relation de',
215 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Est un sous-attribut de',
 214+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
216215 SMW_SP_MAIN_DISPLAY_UNIT => 'Unité de mesure principale pour l\'affichage',
217216 SMW_SP_DISPLAY_UNIT => 'Unité de mesure',
218217 SMW_SP_IMPORTED_FROM => 'Importé de',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageDe.php
@@ -211,8 +211,7 @@
212212 //always start upper-case
213213 SMW_SP_HAS_TYPE => 'Hat Datentyp',
214214 SMW_SP_HAS_URI => 'Gleichwertige URI',
215 - SMW_SP_IS_SUBRELATION_OF => 'Ist Unterrelation von',
216 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Ist Unterattribut von',
 215+ SMW_SP_SUBPROPERTY_OF => 'Untereigenschaft von',
217216 SMW_SP_MAIN_DISPLAY_UNIT => 'Erste Ausgabeeinheit',
218217 // SMW_SP_MAIN_DISPLAY_UNIT => 'Primärmaßeinheit für Schirmanzeige', // Great! We really should keep this wonderful translation here! Still, I am not fully certain about my versions either. -- mak
219218 SMW_SP_DISPLAY_UNIT => 'Ausgabeeinheit',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguagePl.php
@@ -246,8 +246,7 @@
247247 //always start upper-case
248248 SMW_SP_HAS_TYPE => 'Ma typ',
249249 SMW_SP_HAS_URI => 'Równoważne URI',
250 - SMW_SP_IS_SUBRELATION_OF => 'Jest podrelacją',
251 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Jest podatrybutem',
 250+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
252251 SMW_SP_MAIN_DISPLAY_UNIT => 'Główna wyświetlana jednostka',
253252 SMW_SP_DISPLAY_UNIT => 'Wyświetlana jednostka',
254253 SMW_SP_IMPORTED_FROM => 'Zaimportowane z',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageHe.php
@@ -218,8 +218,7 @@
219219 //always start upper-case
220220 SMW_SP_HAS_TYPE => 'מטיפוס',
221221 SMW_SP_HAS_URI => 'מזהה יחודי תואם',
222 - SMW_SP_IS_SUBRELATION_OF => 'זהו תת-יחס של',
223 - SMW_SP_IS_SUBATTRIBUTE_OF => 'זוהי תכונה בת של',
 222+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
224223 SMW_SP_MAIN_DISPLAY_UNIT => 'יחידת הצגה ראשית',
225224 SMW_SP_DISPLAY_UNIT => 'יחידת הצגה',
226225 SMW_SP_IMPORTED_FROM => 'יובא מ',
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_LanguageSk.php
@@ -220,8 +220,7 @@
221221 //always start upper-case
222222 SMW_SP_HAS_TYPE => 'Má typ',
223223 SMW_SP_HAS_URI => 'Ekvivalent URI',
224 - SMW_SP_IS_SUBRELATION_OF => 'Je podvvzťahom',
225 - SMW_SP_IS_SUBATTRIBUTE_OF => 'Je podatribútom',
 224+ SMW_SP_SUBPROPERTY_OF => 'Subproperty of', // TODO: translate
226225 SMW_SP_MAIN_DISPLAY_UNIT => 'Hlavná zobrazovacia jednotka',
227226 SMW_SP_DISPLAY_UNIT => 'Zobrazovacia jednotka',
228227 SMW_SP_IMPORTED_FROM => 'Importovaný z',

Status & tagging log