r24035 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24034‎ | r24035 | r24036 >
Date:15:41, 12 July 2007
Author:brion
Status:old
Tags:
Comment:
* Fix for Esperanto double-x-encoding in move success page
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialMovepage.php
@@ -268,11 +268,16 @@
269269 function showSuccess() {
270270 global $wgOut, $wgRequest, $wgUser, $wgRawHtml;
271271
 272+ $old = Title::newFromText( $wgRequest->getVal( 'oldtitle' ) );
 273+ $new = Title::newFromText( $wgRequest->getVal( 'newtitle' ) );
 274+
 275+ if( is_null( $old ) || is_null( $new ) ) {
 276+ throw new ErrorPageError( 'badtitle', 'badtitletext' );
 277+ }
 278+
272279 $wgOut->setPagetitle( wfMsg( 'movepage' ) );
273280 $wgOut->setSubtitle( wfMsg( 'pagemovedsub' ) );
274281
275 - $old = Title::newFromText( $wgRequest->getText( 'oldtitle' ) );
276 - $new = Title::newFromText( $wgRequest->getText( 'newtitle' ) );
277282 $talkmoved = $wgRequest->getVal( 'talkmoved' );
278283 $oldUrl = $old->getFullUrl( 'redirect=no' );
279284 $newUrl = $new->getFullURl();
Index: trunk/phase3/RELEASE-NOTES
@@ -279,6 +279,8 @@
280280 * (bug 10332) Title->userCan( 'edit' ) may return false positive
281281 * Fix bug with <nowiki> in front of links for wikis where linkPrefixExtension is true
282282 * (bug 10552) Suppress rollback link in history for single-revision pages
 283+* (bug 10538) Gracefully handle invalid input on move success page
 284+* Fix for Esperanto double-x-encoding in move success page
283285
284286
285287 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log