r24027 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24026‎ | r24027 | r24028 >
Date:08:43, 12 July 2007
Author:raymond
Status:old
Tags:
Comment:
Use appropriate message for talk page links.
Localization was broken for user language != content language
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
@@ -132,7 +132,7 @@
133133 * @param Skin $skin
134134 */
135135 private function showTitles( $titles, $output, $skin ) {
136 - $talk = htmlspecialchars( $GLOBALS['wgContLang']->getFormattedNsText( NS_TALK ) );
 136+ $talk = wfMsgHtml( 'talkpagelinktext' );
137137 // Do a batch existence check
138138 $batch = new LinkBatch();
139139 foreach( $titles as $title ) {
@@ -410,8 +410,7 @@
411411 $link = $skin->makeLinkObj( $title );
412412 if( $redirect )
413413 $link = '<span class="watchlistredir">' . $link . '</span>';
414 - $tools[] = $skin->makeLinkObj( $title->getTalkPage(),
415 - htmlspecialchars( $GLOBALS['wgContLang']->getFormattedNsText( NS_TALK ) ) );
 414+ $tools[] = $skin->makeLinkObj( $title->getTalkPage(), wfMsgHtml( 'talkpagelinktext' ) );
416415 if( $title->exists() )
417416 $tools[] = $skin->makeKnownLinkObj( $title, wfMsgHtml( 'history_short' ), 'action=history' );
418417 return '<li>'

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log