r24008 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24007‎ | r24008 | r24009 >
Date:14:50, 11 July 2007
Author:brion
Status:old
Tags:
Comment:
Revert r23999 -- too-specific class names are annoying and unmaintainable.
This is CSS -- use selectors for that!
Modified paths:
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DifferenceEngine.php
@@ -157,7 +157,7 @@
158158 $rollback = '';
159159 }
160160 if( $wgUseRCPatrol && $this->mRcidMarkPatrolled != 0 && $wgUser->isAllowed( 'patrol' ) ) {
161 - $patrol = '<span class="mw-diff-patrol"> [' . $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'markaspatrolleddiff' ), "action=markpatrolled&rcid={$this->mRcidMarkPatrolled}" ) . ']</span>';
 161+ $patrol = ' [' . $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'markaspatrolleddiff' ), "action=markpatrolled&rcid={$this->mRcidMarkPatrolled}" ) . ']';
162162 } else {
163163 $patrol = '';
164164 }
@@ -573,7 +573,7 @@
574574 $newEdit = $this->mNewPage->escapeLocalUrl( 'action=edit' );
575575
576576 $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a> ($timestamp)"
577 - . "<span class=\"mw-diff-edit\"> (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)</span>";
 577+ . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
578578
579579 } else {
580580 $newLink = $this->mNewPage->escapeLocalUrl( 'oldid=' . $this->mNewid );
@@ -581,7 +581,7 @@
582582 $this->mPagetitle = htmlspecialchars( wfMsg( 'revisionasof', $timestamp ) );
583583
584584 $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>"
585 - . "<span class=\"mw-diff-edit\"> (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)</span>";
 585+ . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
586586 }
587587
588588 // Load the old revision object
@@ -611,10 +611,10 @@
612612 $oldLink = $this->mOldPage->escapeLocalUrl( 'oldid=' . $this->mOldid );
613613 $oldEdit = $this->mOldPage->escapeLocalUrl( 'action=edit&oldid=' . $this->mOldid );
614614 $this->mOldtitle = "<a href='$oldLink'>" . htmlspecialchars( wfMsg( 'revisionasof', $t ) )
615 - . "</a><span class=\"mw-diff-edit\"> (<a href='$oldEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)</span>";
 615+ . "</a> (<a href='$oldEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
616616 //now that we considered old rev, we can make undo link (bug 8133, multi-edit undo)
617617 $newUndo = $this->mNewPage->escapeLocalUrl( 'action=edit&undoafter=' . $this->mOldid . '&undo=' . $this->mNewid);
618 - $this->mNewtitle .= "<span class=\"mw-diff-undo\"> (<a href='$newUndo'>" . htmlspecialchars( wfMsg( 'editundo' ) ) . "</a>)</span>";
 618+ $this->mNewtitle .= " (<a href='$newUndo'>" . htmlspecialchars( wfMsg( 'editundo' ) ) . "</a>)";
619619 }
620620
621621 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23999Adding a few CSS classes per request on de.wikiraymond11:31, 11 July 2007

Status & tagging log