r23932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r23931‎ | r23932 | r23933 >
Date:01:32, 10 July 2007
Author:simetrical
Status:old
Tags:
Comment:
(bug 10413) DISPLAYTITLE doesn't escape HTML entities, causing the displayed title to a) be wrong and b) not normalize to the actual title. No RELEASE-NOTES because this feature was only added this release anyway. Patch based on one by WebBoy.
Modified paths:
  • /trunk/phase3/includes/CoreParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CoreParserFunctions.php
——@@ -107,7 +107,7 @@
108108 * @return string
109109 */
110110 static function displaytitle( $parser, $text = '' ) {
111 - $text = trim( $text );
 111+ $text = trim( Sanitizer::decodeCharReferences( $text ) );
112112 $title = Title::newFromText( $text );
113113 if( $title instanceof Title && $title->getFragment() == '' && $title->equals( $parser->mTitle ) )
114114 $parser->mOutput->setDisplayTitle( $text );

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log